✗ CI.checkpatch: warning for series starting with [1/2] drm/gem: Fix race in drm_gem_handle_create_tail() (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed Jul 9 13:57:48 UTC 2025
== Series Details ==
Series: series starting with [1/2] drm/gem: Fix race in drm_gem_handle_create_tail() (rev2)
URL : https://patchwork.freedesktop.org/series/151277/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
43254c2aa575037fc031c7ac21b0d031c700b2bf
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit df0d2746a503e35814e246f2ad2a9146d3eff3e2
Author: Simona Vetter <simona.vetter at ffwll.ch>
Date: Wed Jul 9 15:52:20 2025 +0200
drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code
The object is potentially already gone after the drm_gem_object_put().
In general the object should be fully constructed before calling
drm_gem_handle_create(), except the debugfs tracking uses a separate
lock and list and separate flag to denotate whether the object is
actually initilized.
Since I'm touching this all anyway simplify this by only adding the
object to the debugfs when it's ready for that, which allows us to
delete that separate flag. panthor_gem_debugfs_bo_rm() already checks
whether we've actually been added to the list or this is some error
path cleanup.
v2: Fix build issues for !CONFIG_DEBUGFS (Adrián)
v3: Add linebreak and remove outdated comment (Liviu)
Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
Cc: Adrián Larumbe <adrian.larumbe at collabora.com>
Cc: Boris Brezillon <boris.brezillon at collabora.com>
Cc: Steven Price <steven.price at arm.com>
Cc: Liviu Dudau <liviu.dudau at arm.com>
Reviewed-by: Liviu Dudau <liviu.dudau at arm.com>
Signed-off-by: Simona Vetter <simona.vetter at intel.com>
Signed-off-by: Simona Vetter <simona.vetter at ffwll.ch>
+ /mt/dim checkpatch 0cc3f2731cb8e77b27ffb7f361407fd240276ed5 drm-intel
af5595056eb8 drm/gem: Fix race in drm_gem_handle_create_tail()
-:42: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit f6cd7daecff5 ("drm: Release driver references to handle before making it available again")'
#42:
Note that the close-side of this race was fixed in f6cd7daecff5 ("drm:
-:73: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#73:
Reported-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
-:116: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj"
#116: FILE: drivers/gpu/drm/drm_gem.c:476:
+ WARN_ON(obj != NULL);
-:134: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?
total: 1 errors, 2 warnings, 1 checks, 37 lines checked
df0d2746a503 drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code
-:14: WARNING:TYPO_SPELLING: 'initilized' may be misspelled - perhaps 'initialized'?
#14:
actually initilized.
^^^^^^^^^^
total: 0 errors, 1 warnings, 0 checks, 88 lines checked
More information about the Intel-xe
mailing list