[PATCH v8 02/13] drm/xe: Correct the rev value for the DVSEC entries

David Box david.e.box at linux.intel.com
Sun Jul 13 23:11:16 UTC 2025


On Sun, Jul 13, 2025 at 01:29:32PM -0400, Michael J. Ruhl wrote:
> By definition, the Designated Vendor Specific Extended Capability
> (DVSEC) revision should be 1.
> 
> Add the rev value to be correct.
> 
> Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vsec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index 3e573b0b7ebd..d279e0ace7d7 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
> @@ -24,6 +24,7 @@
>  #define BMG_DEVICE_ID 0xE2F8
>  
>  static struct intel_vsec_header bmg_telemetry = {
> +	.rev = 1,
>  	.length = 0x10,
>  	.id = VSEC_ID_TELEMETRY,
>  	.num_entries = 2,
> @@ -33,6 +34,7 @@ static struct intel_vsec_header bmg_telemetry = {
>  };
>  
>  static struct intel_vsec_header bmg_punit_crashlog = {
> +	.rev = 1,
>  	.length = 0x10,
>  	.id = VSEC_ID_CRASHLOG,
>  	.num_entries = 1,
> @@ -42,6 +44,7 @@ static struct intel_vsec_header bmg_punit_crashlog = {
>  };
>  
>  static struct intel_vsec_header bmg_oobmsm_crashlog = {
> +	.rev = 1,
>  	.length = 0x10,
>  	.id = VSEC_ID_CRASHLOG,
>  	.num_entries = 1,
> -- 
> 2.50.0
> 
> 

Reviewed-by: David E. Box <david.e.box at linux.intel.com>


More information about the Intel-xe mailing list