✗ CI.checkpatch: warning for drm/i915: PREEMPT_RT related fixups. (rev6)

[Patchwork]

== Series Details ==

Series: drm/i915: PREEMPT_RT related fixups. (rev6)
URL   : https://patchwork.freedesktop.org/series/132082/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
43254c2aa575037fc031c7ac21b0d031c700b2bf
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3c01c318ede839384c3bad0b683e47c308cac3a8
Author: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
Date:   Mon Jul 14 17:39:54 2025 +0200

    Revert "drm/i915: Depend on !PREEMPT_RT."
    
    Once the known issues are addressed, it should be safe to enable the
    driver.
    
    Acked-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
+ /mt/dim checkpatch 83838c0b69ca6dfadc90247a517638ca73a9c3d0 drm-intel
e803ab82673a drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
  ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.")

-:44: WARNING:LINE_SPACING: Missing a blank line after declarations
#44: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:320:
+	struct drm_i915_private *i915 = to_i915(display->drm);
+	spin_lock_irqsave(&i915->uncore.lock, *flags);

-:51: WARNING:LINE_SPACING: Missing a blank line after declarations
#51: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:327:
+	struct drm_i915_private *i915 = to_i915(display->drm);
+	spin_unlock_irqrestore(&i915->uncore.lock, flags);

total: 0 errors, 3 warnings, 0 checks, 78 lines checked
4bd472c9af6c drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates
-:10: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10: 
started disabling interrupts across atomic updates. This breaks on PREEMPT_RT

total: 0 errors, 1 warnings, 0 checks, 68 lines checked
9168ff945fad drm/i915: Don't check for atomic context on PREEMPT_RT
-:35: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#35: FILE: drivers/gpu/drm/i915/i915_utils.h:276:
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG) && IS_ENABLED(CONFIG_PREEMPT_COUNT) && !defined(CONFIG_PREEMPT_RT)

total: 0 errors, 1 warnings, 0 checks, 15 lines checked
1072a90192dd drm/i915: Disable tracing points on PREEMPT_RT
-:27: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#27: 
Reported-by: Luca Abeni <lucabe72 at gmail.com>
Cc: Steven Rostedt <rostedt at goodmis.org>

-:75: WARNING:MISSING_FIXES_TAG: The commit message has 'Call Trace:', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 2 warnings, 0 checks, 30 lines checked
63ba2f0dbe68 drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()
-:22: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#22: 
Reported-by: Clark Williams <williams at redhat.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>

total: 0 errors, 1 warnings, 0 checks, 53 lines checked
a03ce64f156f drm/i915: Drop the irqs_disabled() check
-:16: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#16: 
Reported-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
b95f2e0f32ac drm/i915/guc: Consider also RCU depth in busy loop.
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: "John B. Wyatt IV" <jwyatt at redhat.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

-:26: ERROR:IN_ATOMIC: do not use in_atomic in drivers
#26: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc.h:365:
+	bool not_atomic = !in_atomic() && !irqs_disabled() && !rcu_preempt_depth();

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
dd70550c799a drm/i915: Consider RCU read section as atomic.
-:26: WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#26: FILE: drivers/gpu/drm/i915/gt/intel_engine_cs.c:1612:
+	if (in_atomic() || irqs_disabled() || rcu_preempt_depth()) /* inside atomic preempt-reset? */

-:26: ERROR:IN_ATOMIC: do not use in_atomic in drivers
#26: FILE: drivers/gpu/drm/i915/gt/intel_engine_cs.c:1612:
+	if (in_atomic() || irqs_disabled() || rcu_preempt_depth()) /* inside atomic preempt-reset? */

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
3c01c318ede8 Revert "drm/i915: Depend on !PREEMPT_RT."