[PATCH] drm/xe: Fix build without debugfs

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Wed Jul 23 03:25:08 UTC 2025



On 23-07-2025 01:22, Lucas De Marchi wrote:
> When CONFIG_DEBUG_FS is off, drivers/gpu/drm/xe/xe_gt_debugfs.o
> is not built and build fails on some setups with:
> 
> 	ld: drivers/gpu/drm/xe/xe_gt.o: in function `xe_fault_inject_gt_reset':
> 	drivers/gpu/drm/xe/xe_gt.h:27:(.text+0x1659): undefined reference to `gt_reset_failure'
> 	ld: drivers/gpu/drm/xe/xe_gt.h:27:(.text+0x1c16): undefined reference to `gt_reset_failure'
> 	collect2: error: ld returned 1 exit status
> 
> Do not use the gt_reset_failure attribute if debugfs is not enabled.
> 
> Fixes: 8f3013e0b222 ("drm/xe: Introduce fault injection for gt reset")
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> Acked-by: Randy Dunlap <rdunlap at infradead.org>
> Tested-by: Randy Dunlap <rdunlap at infradead.org>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Change LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

> ---
>   drivers/gpu/drm/xe/xe_gt.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.h b/drivers/gpu/drm/xe/xe_gt.h
> index e9ccab8aedbef..41880979f4ded 100644
> --- a/drivers/gpu/drm/xe/xe_gt.h
> +++ b/drivers/gpu/drm/xe/xe_gt.h
> @@ -24,7 +24,7 @@
>   extern struct fault_attr gt_reset_failure;
>   static inline bool xe_fault_inject_gt_reset(void)
>   {
> -	return should_fail(&gt_reset_failure, 1);
> +	return IS_ENABLED(CONFIG_DEBUG_FS) && should_fail(&gt_reset_failure, 1);
>   }
>   
>   struct xe_gt *xe_gt_alloc(struct xe_tile *tile);
> 
> 
> 



More information about the Intel-xe mailing list