[CI v4 0/7] Relax VF/PF version negotiation

Lucas De Marchi lucas.demarchi at intel.com
Thu Jul 17 15:51:16 UTC 2025 

+Joe Perches

we seem to have some odd behavior in get_maintainer.pl. Could you
clarify below?

On Thu, Jul 17, 2025 at 04:38:19PM +0200, Michal Wajdeczko wrote:
>Hi Maxime,
>
>On 17.07.2025 13:44, Maxime Ripard wrote:
>> Hi Michal,
>>
>> On Mon, Jul 14, 2025 at 06:34:10PM +0200, Michal Wajdeczko wrote:
>>> On 13.07.2025 12:36, Michal Wajdeczko wrote:
>>>> It was clarified by the arch team that initial version negotiation
>>>> can be done by the VF just once, by using any available GuC/GT.
>>>>
>>>> v1: https://patchwork.freedesktop.org/series/150711/#rev1
>>>> v2: https://patchwork.freedesktop.org/series/150711/#rev2
>>>>  - don't WARN on missed mandatory print func (Piotr)
>>>>  - use gt_is_main/tile_is_root helpers (Piotr)
>>>>  - drop leftover test include (Piotr)
>>>>  - add more asserts (Piotr)
>>>> v3: rebased
>>>> v4: rebased again (there was no CI.FULL for v3)
>>>>
>>>> Michal Wajdeczko (7):
>>>>   drm/xe: Combine PF and VF device data into union
>>>>   drm/xe: Move PF and VF device types to separate headers
>>>>   drm/xe: Introduce xe_tile_is_root helper
>>>>   drm/xe: Introduce xe_gt_is_main_type helper
>>>>   drm/xe/pf: Expose basic info about VFs in debugfs
>>>>   drm/xe/pf: Stop requiring VF/PF version negotiation on every GT
>>>>   drm/xe/vf: Store negotiated VF/PF ABI version at device level
>>>>
>>>>  drivers/gpu/drm/xe/Makefile                   |   3 +-
>>>>  .../xe/tests/xe_gt_sriov_pf_service_test.c    | 232 ------------------
>>>>  .../drm/xe/tests/xe_sriov_pf_service_kunit.c  | 227 +++++++++++++++++
>>>>  drivers/gpu/drm/xe/xe_bb.c                    |   2 +-
>>>>  drivers/gpu/drm/xe/xe_debugfs.c               |   4 +
>>>>  drivers/gpu/drm/xe/xe_device_types.h          |  12 +-
>>>>  drivers/gpu/drm/xe/xe_force_wake.c            |   2 +-
>>>>  drivers/gpu/drm/xe/xe_gsc_proxy.c             |   3 +-
>>>>  drivers/gpu/drm/xe/xe_gt.c                    |  12 +-
>>>>  drivers/gpu/drm/xe/xe_gt.h                    |   5 +
>>>>  drivers/gpu/drm/xe/xe_gt_idle.c               |   2 +-
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c    |  30 +--
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c   |   7 +-
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c   |   9 +-
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_service.c   | 166 +------------
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_service.h   |   2 -
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_vf.c           |  34 +--
>>>>  drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h     |  12 -
>>>>  drivers/gpu/drm/xe/xe_irq.c                   |   7 +-
>>>>  drivers/gpu/drm/xe/xe_oa.c                    |   6 +-
>>>>  drivers/gpu/drm/xe/xe_sriov_pf.c              |  61 ++++-
>>>>  drivers/gpu/drm/xe/xe_sriov_pf.h              |   6 +
>>>>  drivers/gpu/drm/xe/xe_sriov_pf_service.c      | 216 ++++++++++++++++
>>>>  drivers/gpu/drm/xe/xe_sriov_pf_service.h      |  23 ++
>>>>  .../gpu/drm/xe/xe_sriov_pf_service_types.h    |  36 +++
>>>>  drivers/gpu/drm/xe/xe_sriov_pf_types.h        |  45 ++++
>>>>  drivers/gpu/drm/xe/xe_sriov_types.h           |  36 ---
>>>>  drivers/gpu/drm/xe/xe_sriov_vf_types.h        |  41 ++++
>>>>  drivers/gpu/drm/xe/xe_tile.h                  |   6 +
>>>>  29 files changed, 744 insertions(+), 503 deletions(-)
>>>>  delete mode 100644 drivers/gpu/drm/xe/tests/xe_gt_sriov_pf_service_test.c
>>>>  create mode 100644 drivers/gpu/drm/xe/tests/xe_sriov_pf_service_kunit.c
>>>>  create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service.c
>>>>  create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service.h
>>>>  create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service_types.h
>>>>  create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_types.h
>>>>  create mode 100644 drivers/gpu/drm/xe/xe_sriov_vf_types.h
>>>>
>>>
>>> received offline Acked-by from Rodrigo for patch 2/7 and patch 6/7 to
>>> mitigate below dim warnings, likely due to new files being added:
>>>
>>> $ dim -d push-branch drm-xe-next
>>> dim: WARNING: 7320a508eef0 ("drm/xe/pf: Stop requiring VF/PF version
>>> negotiation on every GT"): Mandatory Maintainer Acked-by missing., but
>>> continuing dry-run
>>> dim: WARNING: c1a58788a937 ("drm/xe: Move PF and VF device types to
>>> separate headers"): Mandatory Maintainer Acked-by missing., but
>>> continuing dry-run
>>
>> I guess they are now the commits a6c384b24f13 and 73c0e8054fcf
>> respectively, right?
>
>correct
>
>>
>> If so, I can't find anything wrong with those. Did you change anything
>> between your mail and when you actually pushed the changes?
>
>this was observed before I've added extra a-b from Rodrigo (with a-b
>there was no warnings any more, that's why I was able to push it)
>
>and the only thing that makes those two patches special/different from
>other in this series, is that both were adding new files:
>
>7320a508eef0 / a6c384b24f13
>
> create mode 100644 drivers/gpu/drm/xe/tests/xe_sriov_pf_service_kunit.c
> create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service.c
> create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service.h
> create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_service_types.h
>
>c1a58788a937 / 73c0e8054fcf
>
> create mode 100644 drivers/gpu/drm/xe/xe_sriov_pf_types.h
> create mode 100644 drivers/gpu/drm/xe/xe_sriov_vf_types.h
>
>and likely dim script was considering this as cross tree merge, in check
>added by you in commit 43254c2aa575 ("dim: Check for maintainer's ack
>when merging on behalf of another tree")
>
>and at that time this is what your magic commands were printing:
>
>$ git show --no-use-mailmap --pretty=email c1a58788a937 |
>./scripts/get_maintainer.pl --no-email --no-l --scm
>git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>git https://gitlab.freedesktop.org/drm/xe/kernel.git
>git https://gitlab.freedesktop.org/drm/kernel.git
>
>$ git show --no-use-mailmap --pretty=email c1a58788a937 |
>./scripts/get_maintainer.pl --no-email --no-l --scm | head -n 1 | cut -d
>" " -f2
>git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>
>so it looks new files patches were classified as "torvalds" not "xe"
>tree, hence the warnings (I guess)


New empty file seems ok:
	$ touch drivers/gpu/drm/xe/test_maint.c
	$ git add drivers/gpu/drm/xe/test_maint.c
	$ git commit -m tmp 
	$ git show --no-use-mailmap --pretty=email HEAD | ./scripts/get_maintainer.pl --no-email --no-l --scm
	git https://gitlab.freedesktop.org/drm/xe/kernel.git
	git https://gitlab.freedesktop.org/drm/kernel.git
	git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

New non-empty file has Linus' tree as the first one:
	$ echo " " > drivers/gpu/drm/xe/test_maint2.c
	$ git add drivers/gpu/drm/xe/test_maint2.c
	$ git commit -m tmp2
	$ git show --no-use-mailmap --pretty=email HEAD | ./scripts/get_maintainer.pl --no-email --no-l --scm
	git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
	git https://gitlab.freedesktop.org/drm/xe/kernel.git
	git https://gitlab.freedesktop.org/drm/kernel.git

Lucas De Marchi

>
>Michal
>
>>
>> Maxime
>

More information about the Intel-xe mailing list