✗ CI.checkpatch: warning for adl auxcss ci run
Patchwork
patchwork at emeril.freedesktop.org
Thu Jul 24 13:49:05 UTC 2025
== Series Details ==
Series: adl auxcss ci run
URL : https://patchwork.freedesktop.org/series/152063/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63535c743231a7497a612c53f6edbb8a7d14412d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f44974e88c48a0663da36137a8e4b4555f6fa9cb
Author: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
Date: Thu Jul 24 14:17:10 2025 +0100
drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe
Now that we have fixed the DPT handling we can undo the nerf which was
done in cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if
built for Xe").
Tested with KDE Wayland, on Lenovo Carbon X1 ADL-P:
[PLANE:32:plane 1A]: type=PRI
uapi: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=visible, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)
hw: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=yes, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)
Display working fine - no artefacts, no DMAR/PIPE faults.
v2:
* Adjust patch title. (Rodrigo)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
References: cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if built for Xe")
Cc: José Roberto de Souza <jose.souza at intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch add9d6a10141822e2c828645804801123e937e86 drm-intel
d5c286d4f7fe drm/xe: Use emit_flush_imm_ggtt helper instead of open coding
de6172817b53 drm/xe/xelpg: Flush CCS when flushing caches
8bd9d9c4b423 drm/xe/xelp: Quiesce memory traffic before invalidating auxccs
4c782f87d7d9 drm/xe/xelp: Support auxccs invalidation on blitter
4d29e9616893 drm/xe/xelp: Use MI_FLUSH_DW_CCS on auxccs platforms
7f472cd28480 drm/xe/xelp: Wait for AuxCCS invalidation to complete
a45fbc3e70ca drm/xe: Export xe_emit_aux_table_inv
89575f90a144 drm/xe/xelp: Add AuxCCS invalidation to the indirect context workarounds
998d088d62d8 drm/xe: Flush GGTT writes after populating DPT
-:72: WARNING:MEMORY_BARRIER: memory barrier without comment
#72: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:115:
+ wmb();
total: 0 errors, 1 warnings, 0 checks, 66 lines checked
54b2f9e60c74 drm/xe: Handle DPT in system memory
2606e9051563 drm/xe/display: Add support for AuxCCS
4ec54e015998 drm/xe: Force flush system memory AuxCCS data before scan out
-:58: WARNING:MEMORY_BARRIER: memory barrier without comment
#58: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:400:
+ mb();
-:61: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#61: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:403:
+ uint8_t *page_virtual;
-:64: WARNING:DEPRECATED_API: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead
#64: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:406:
+ page_virtual = kmap_atomic(page);
-:67: WARNING:DEPRECATED_API: Deprecated use of 'kunmap_atomic', prefer 'kunmap_local' instead
#67: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:409:
+ kunmap_atomic(page_virtual);
-:69: WARNING:MEMORY_BARRIER: memory barrier without comment
#69: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:411:
+ mb();
total: 0 errors, 4 warnings, 1 checks, 103 lines checked
f44974e88c48 drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if built for Xe")'
#10:
done in cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if
-:16: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#16:
uapi: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=visible, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)
total: 1 errors, 1 warnings, 0 checks, 12 lines checked
More information about the Intel-xe
mailing list