[CI 01/13] drm/xe: Use emit_flush_imm_ggtt helper instead of open coding

Lucas De Marchi lucas.demarchi at intel.com
Thu Jul 24 14:49:25 UTC 2025


On Thu, Jul 24, 2025 at 02:16:58PM +0100, Tvrtko Ursulin wrote:
>Helper is already there so lets just use it.
>
>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
>Reviewed-by: Matthew Brost <matthew.brost at intel.com>

no behavior change in this particular patch,
pushed to drm-xe-next.

thanks,
Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_ring_ops.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
>index 7b50c7c1ee21..e8f22ec5f9af 100644
>--- a/drivers/gpu/drm/xe/xe_ring_ops.c
>+++ b/drivers/gpu/drm/xe/xe_ring_ops.c
>@@ -415,11 +415,9 @@ static void emit_migration_job_gen12(struct xe_sched_job *job,
>
> 	i = emit_bb_start(job->ptrs[1].batch_addr, BIT(8), dw, i);
>
>-	dw[i++] = MI_FLUSH_DW | MI_INVALIDATE_TLB | job->migrate_flush_flags |
>-		MI_FLUSH_DW_OP_STOREDW | MI_FLUSH_IMM_DW;
>-	dw[i++] = xe_lrc_seqno_ggtt_addr(lrc) | MI_FLUSH_DW_USE_GTT;
>-	dw[i++] = 0;
>-	dw[i++] = seqno; /* value */
>+	i = emit_flush_imm_ggtt(xe_lrc_seqno_ggtt_addr(lrc), seqno,
>+				MI_INVALIDATE_TLB | job->migrate_flush_flags,
>+				dw, i);
>
> 	i = emit_user_interrupt(dw, i);
>
>-- 
>2.48.0
>


More information about the Intel-xe mailing list