✗ CI.checkpatch: warning for Fair DRM scheduler (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Jul 24 15:31:12 UTC 2025


== Series Details ==

Series: Fair DRM scheduler (rev2)
URL   : https://patchwork.freedesktop.org/series/151321/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63535c743231a7497a612c53f6edbb8a7d14412d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c72b95a54870bf9038bdf08a86f0ffda7316bb63
Author: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
Date:   Thu Jul 24 15:19:21 2025 +0100

    drm/sched: Embed run queue singleton into the scheduler
    
    Now that the run queue to scheduler relationship is always 1:1 we can
    embed it (the run queue) directly in the scheduler struct and save on
    some allocation error handling code and such.
    
    Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
    Cc: Christian König <christian.koenig at amd.com>
    Cc: Danilo Krummrich <dakr at kernel.org>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: Philipp Stanner <phasta at kernel.org>
+ /mt/dim checkpatch 2fe30dbc18cd98a593fa26398fe0147381ca716a drm-intel
5a66905b6282 drm/sched: Add some scheduling quality unit tests
-:41: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#41: 
    0: prio=normal sync=0 elapsed_ms=1015ms (ideal_ms=1000ms) cycle_time(min,avg,max)=134,222,978 us latency_time(min,avg,max)=134,222,978

-:124: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#124: 
new file mode 100644

-:140: WARNING:REPEATED_WORD: Possible repeated word: 'scheduler'
#140: FILE: drivers/gpu/drm/scheduler/tests/tests_scheduler.c:12:
+ * DRM scheduler scheduler tests exercise load balancing decisions ie. entity

-:630: WARNING:REPEATED_WORD: Possible repeated word: 'from'
#630: FILE: drivers/gpu/drm/scheduler/tests/tests_scheduler.c:502:
+	 * Same job stream from from two clients.

total: 0 errors, 4 warnings, 0 checks, 648 lines checked
606dd2efa10d drm/sched: Add some more scheduling quality unit tests
-:25: WARNING:REPEATED_WORD: Possible repeated word: 'test'
#25: 
Every 100ms for the duration of the test test logs how many jobs each

-:54: CHECK:LINE_SPACING: Please don't use multiple blank lines
#54: FILE: drivers/gpu/drm/scheduler/tests/tests_scheduler.c:639:
 
+

total: 0 errors, 1 warnings, 1 checks, 197 lines checked
341b6171e03f drm/sched: Implement RR via FIFO
8ad766ff30ae drm/sched: Consolidate entity run queue management
546efb148873 drm/sched: Move run queue related code into a separate file
-:289: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#289: 
new file mode 100644

-:294: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#294: FILE: drivers/gpu/drm/scheduler/sched_rq.c:1:
+#include <linux/rbtree.h>

total: 0 errors, 2 warnings, 0 checks, 475 lines checked
084d90032758 drm/sched: Free all finished jobs at once
5747d040b768 drm/sched: Account entity GPU time
-:36: CHECK:LINE_SPACING: Please don't use multiple blank lines
#36: FILE: drivers/gpu/drm/scheduler/sched_entity.c:35:
 
+

-:113: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#113: FILE: drivers/gpu/drm/scheduler/sched_internal.h:19:
+	spinlock_t	lock;

total: 0 errors, 0 warnings, 2 checks, 188 lines checked
f7c49bb242a9 drm/sched: Remove idle entity from tree
1b13cde4a9ab drm/sched: Add fair scheduling policy
-:70: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#70: FILE: drivers/gpu/drm/scheduler/sched_entity.c:141:
+			p = max_t(s32,
+				 (s32)sched_list[0]->num_user_rqs - 1,

-:127: WARNING:LONG_LINE: line length of 249 exceeds 100 columns
#127: FILE: drivers/gpu/drm/scheduler/sched_main.c:93:
+MODULE_PARM_DESC(sched_policy, "Specify the scheduling policy for entities on a run-queue, " __stringify(DRM_SCHED_POLICY_RR) " = Round Robin, " __stringify(DRM_SCHED_POLICY_FIFO) " = FIFO, " __stringify(DRM_SCHED_POLICY_FAIR) " = Fair (default).");

total: 0 errors, 1 warnings, 1 checks, 330 lines checked
51d0aed23fef drm/sched: Break submission patterns with some randomness
-:69: ERROR:INITIALISED_STATIC: do not initialise statics to 0
#69: FILE: drivers/gpu/drm/scheduler/sched_rq.c:152:
+			static bool r = 0;

total: 1 errors, 0 warnings, 0 checks, 16 lines checked
2dd4b5d314ed drm/sched: Remove FIFO and RR and simplify to a single run queue
-:304: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#304: FILE: drivers/gpu/drm/scheduler/sched_main.c:1145:
 {
+

total: 0 errors, 0 warnings, 1 checks, 524 lines checked
c72b95a54870 drm/sched: Embed run queue singleton into the scheduler




More information about the Intel-xe mailing list