[PATCH v1] drm/xe/uc: Add xe_uc_stop on hardware initialization error handling

[Lucas De Marchi]

On Thu, Jul 24, 2025 at 12:09:38PM -0400, Dong, Zhanjun wrote:
>Please stop review this patch, issue found and new rev is in progress.

ok, just on the commit message below...

>
>Regards,
>Zhanjun Dong
>
>On 2025-07-24 11:25 a.m., Zhanjun Dong wrote:
>>During hardware initialization, GuC communication is expected, which
>>will increase the outstanding counter. Non-zero counter will cause
>>assertion failed during shutdown process.
>>Add xe_uc_stop call to clear the counter.
>>
>>Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5466
>>Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5530
>>

Please drop this newline. "Closes:" should be part of the git trailer.

Lucas De Marchi

>>Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
>>---
>>  drivers/gpu/drm/xe/xe_uc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>>diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
>>index 465bda355443..6c72ce305d6c 100644
>>--- a/drivers/gpu/drm/xe/xe_uc.c
>>+++ b/drivers/gpu/drm/xe/xe_uc.c
>>@@ -173,6 +173,7 @@ static int vf_uc_load_hw(struct xe_uc *uc)
>>  	return 0;
>>  err_out:
>>+	xe_uc_stop(uc);
>>  	xe_guc_sanitize(&uc->guc);
>>  	return err;
>>  }
>>@@ -228,6 +229,7 @@ int xe_uc_load_hw(struct xe_uc *uc)
>>  	return 0;
>>  err_out:
>>+	xe_uc_stop(uc);
>>  	xe_guc_sanitize(&uc->guc);
>>  	return ret;
>>  }
>