[PATCH] drm/xe/hw_engine_group: Don't use drm_warn to catch missed case

Francois Dugast francois.dugast at intel.com
Fri Jul 25 10:01:59 UTC 2025


On Fri, Jul 25, 2025 at 11:05:08AM +0200, Michal Wajdeczko wrote:
> Since hwe->class is an enumeration we can rely on the compiler
> to catch any unhandled engine class case at compile time thanks
> to [-Werror=switch]. Any unexpected use of a special CLASS_MAX
> enum case can be guarded by our xe_gt_assert() instead, which
> will be compiled-out on the production builds.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Francois Dugast <francois.dugast at intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>

Reviewed-by: Francois Dugast <francois.dugast at intel.com>

It seems there are a few other cases in drivers/gpu/drm/xe/xe_pt.c.

> ---
>  drivers/gpu/drm/xe/xe_hw_engine_group.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_group.c b/drivers/gpu/drm/xe/xe_hw_engine_group.c
> index c926f840c87b..58bee3ffe881 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_group.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_group.c
> @@ -103,8 +103,8 @@ int xe_hw_engine_setup_groups(struct xe_gt *gt)
>  			break;
>  		case XE_ENGINE_CLASS_OTHER:
>  			break;
> -		default:
> -			drm_warn(&xe->drm, "NOT POSSIBLE");
> +		case XE_ENGINE_CLASS_MAX:
> +			xe_gt_assert(gt, false);
>  		}
>  	}
>  
> -- 
> 2.47.1
> 


More information about the Intel-xe mailing list