✗ CI.checkpatch: warning for drm/xe/xe_guc_ads: Consolidate guc_waklv_enable functions (rev3)

[Patchwork]

== Series Details ==

Series: drm/xe/xe_guc_ads: Consolidate guc_waklv_enable functions (rev3)
URL   : https://patchwork.freedesktop.org/series/152099/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63535c743231a7497a612c53f6edbb8a7d14412d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 68eab6b00240dc781cffa8ce57bc71f90152494f
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Fri Jul 25 18:54:45 2025 +0000

    drm/xe/xe_guc_ads: Consolidate guc_waklv_enable functions
    
    Presently, multiple versions of the guc_waklv_enable_.* function exist,
    all with different numbers of dwords added to the klv_entry array.  This
    is not extensible, and more duplicates of the function will need to be
    created if it ever becomes necessary to support 3 or more dwords per wa
    in the future.
    
    Consolidate the disparate guc_waklv_enable functions into a single
    guc_waklv_enable function that can take an arbitrary number of dword
    values.
    
    v2:
    - Update length value properly (Shuicheng)
    
    v3: (Harrison)
    - Use data as a term instead of dwords or arr
    - Reformat warning message to use hex values
    - Eliminate need for kzalloc and klv_entry array
    - Reorder function parameters to fix line wrapping
    
    Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
    Cc: Lucas De Marchi <lucas.demarch at intel.com>
    Cc: Shuicheng Lin <shuicheng.lin at intel.com>
    Cc: John Harrison <john.c.harrison at intel.com>
+ /mt/dim checkpatch 11e629e8c02307977802ba0ea8c60ddb15b17d04 drm-intel
68eab6b00240 drm/xe/xe_guc_ads: Consolidate guc_waklv_enable functions
-:169: WARNING:LINE_SPACING: Missing a blank line after declarations
#169: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:339:
+		u32 data = 0xC40;
+		guc_waklv_enable(ads, &data, sizeof(data)/sizeof(u32), &offset, &remain,

-:169: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#169: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:339:
+		guc_waklv_enable(ads, &data, sizeof(data)/sizeof(u32), &offset, &remain,
 		                                         ^

-:197: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#197: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:355:
+		guc_waklv_enable(ads, data, sizeof(data)/sizeof(u32), &offset, &remain,
 		                                        ^

total: 0 errors, 1 warnings, 2 checks, 166 lines checked