✗ CI.checkpatch: warning for Add TLB invalidation abstraction (rev2)

[Patchwork]

== Series Details ==

Series: Add TLB invalidation abstraction (rev2)
URL   : https://patchwork.freedesktop.org/series/152022/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c298eac5978c38dcc62a70c0d73c91765e7cc296
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit cc0a7a766e1eb3465bc58b86c32eff842ec5f1ba
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Wed Jul 30 20:45:14 2025 +0000

    drm/xe: Split TLB invalidation code in frontend and backend
    
    The frontend exposes an API to the driver to send invalidations, handles
    sequence number assignment, synchronization (fences), and provides a
    timeout mechanism. The backend issues the actual invalidation to the
    hardware (or firmware).
    
    The new layering easily allows issuing TLB invalidations to different
    hardware or firmware interfaces.
    
    Normalize some naming while here too.
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
    Signed-off-by: Stuart Summers <stuart.summers at intel.com>
+ /mt/dim checkpatch bca98310921a3284d7c2f0bc96828f06b3eb7f3a drm-intel
b9ac9cf0691e drm/xe: Move explicit CT lock in TLB invalidation sequence
e2faeae2cc84 drm/xe: s/tlb_invalidation/tlb_inval
-:128: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#128: 
rename from drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c

total: 0 errors, 1 warnings, 0 checks, 1100 lines checked
74101fea3190 drm/xe: Add xe_tlb_inval structure
6d3521b48a85 drm/xe: Add xe_gt_tlb_invalidation_done_handler
b4544329fda2 drm/xe: Decouple TLB invalidations from GT
-:102: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#102: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 1236 lines checked
05ad732e1892 drm/xe: Prep TLB invalidation fence before sending
45f016fe0434 drm/xe: Add helpers to send TLB invalidations
cc0a7a766e1e drm/xe: Split TLB invalidation code in frontend and backend
-:47: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

-:649: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__tlb_inval' - possible side-effects?
#649: FILE: drivers/gpu/drm/xe/xe_tlb_inval.c:215:
+#define xe_tlb_inval_issue(__tlb_inval, __fence, op, args...)	\
+({								\
+	int __ret;						\
+								\
+	xe_assert((__tlb_inval)->xe, (__tlb_inval)->ops);	\
+	xe_assert((__tlb_inval)->xe, (__fence));		\
+								\
+	xe_tlb_inval_fence_prep((__fence));			\
+	__ret = op((__tlb_inval), (__fence)->seqno, ##args);	\
+	if (__ret < 0)						\
+		xe_tlb_inval_fence_signal_unlocked((__fence));	\
+								\
+	__ret == -ECANCELED ? 0 : __ret;			\
+})

-:649: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__fence' - possible side-effects?
#649: FILE: drivers/gpu/drm/xe/xe_tlb_inval.c:215:
+#define xe_tlb_inval_issue(__tlb_inval, __fence, op, args...)	\
+({								\
+	int __ret;						\
+								\
+	xe_assert((__tlb_inval)->xe, (__tlb_inval)->ops);	\
+	xe_assert((__tlb_inval)->xe, (__fence));		\
+								\
+	xe_tlb_inval_fence_prep((__fence));			\
+	__ret = op((__tlb_inval), (__fence)->seqno, ##args);	\
+	if (__ret < 0)						\
+		xe_tlb_inval_fence_signal_unlocked((__fence));	\
+								\
+	__ret == -ECANCELED ? 0 : __ret;			\
+})

total: 0 errors, 1 warnings, 2 checks, 1084 lines checked