✗ CI.checkpatch: warning for drm/i915/display: global state cleanups

[Patchwork]

== Series Details ==

Series: drm/i915/display: global state cleanups
URL   : https://patchwork.freedesktop.org/series/152335/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c298eac5978c38dcc62a70c0d73c91765e7cc296
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a6ab9afd5f8159ca814df4ea6e402bd425e98751
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Thu Jul 31 12:19:22 2025 +0300

    drm/i915/display: keep forward declarations together
    
    Adhere to prevalent style.
    
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 7f74ca5c75dd28bc57d5ea1be165919bc70609d8 drm-intel
b35a2eec4415 drm/i915/display: hide global state iterators, remove unused
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:16:
+#define for_each_new_global_obj_in_state(__state, obj, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:16:
+#define for_each_new_global_obj_in_state(__state, obj, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:16:
+#define for_each_new_global_obj_in_state(__state, obj, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#28: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:24:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#28: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:24:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#28: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:24:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#36: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:32:
+#define for_each_oldnew_global_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#36: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:32:
+#define for_each_oldnew_global_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#36: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:32:
+#define for_each_oldnew_global_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->num_global_objs && \
+		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, \
+		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \
+	     (__i)++) \
+		for_each_if(obj)

total: 0 errors, 0 warnings, 9 checks, 65 lines checked
7a64eac78bfb drm/i915/display: make struct __intel_global_objs_state opaque
a6ab9afd5f81 drm/i915/display: keep forward declarations together