[PATCH 2/3] drm/xe/topology: Use register array size instead magic number

[Matt Roper]

On Wed, Jun 04, 2025 at 10:29:07PM +0200, Michal Wajdeczko wrote:
> Since we keep registers in the array we can simply count them and
> stop relying on magic number when checking if didn't make mistake.
> 
> Also we can switch to use xe_gt_assert() since it could be just
> our programming mistake during platform bringup, no need to keep
> drm_WARN() in the production driver.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt_topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c
> index 62bfb6e1a166..048743913b36 100644
> --- a/drivers/gpu/drm/xe/xe_gt_topology.c
> +++ b/drivers/gpu/drm/xe/xe_gt_topology.c
> @@ -236,8 +236,8 @@ xe_gt_topology_init(struct xe_gt *gt)
>  	 * Register counts returned shouldn't exceed the number of registers
>  	 * passed as parameters below.
>  	 */
> -	drm_WARN_ON(&xe->drm, num_geometry_regs > 3);
> -	drm_WARN_ON(&xe->drm, num_compute_regs > 3);
> +	xe_gt_assert(gt, num_geometry_regs <= ARRAY_SIZE(geometry_regs));
> +	xe_gt_assert(gt, num_compute_regs <= ARRAY_SIZE(compute_regs));
>  
>  	load_dss_mask(gt, gt->fuse_topo.g_dss_mask,
>  		      num_geometry_regs, geometry_regs);
> -- 
> 2.47.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation