[PATCH 9/9] drm/i915/xe3lpd: Extend WA 16023981245 for display 30.02

[Bhadane, Dnyaneshwar]

> -----Original Message-----
> From: Roper, Matthew D <matthew.d.roper at intel.com>
> Sent: Monday, June 9, 2025 8:39 PM
> To: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane at intel.com>
> Cc: Vivekanandan, Balasubramani <balasubramani.vivekanandan at intel.com>;
> intel-xe at lists.freedesktop.org
> Subject: Re: [PATCH 9/9] drm/i915/xe3lpd: Extend WA 16023981245 for display
> 30.02
> 
> On Mon, Jun 09, 2025 at 08:21:20AM +0000, Bhadane, Dnyaneshwar wrote:
> >
> >
> > > -----Original Message-----
> > > From: Vivekanandan, Balasubramani
> > > <balasubramani.vivekanandan at intel.com>
> > > Sent: Monday, June 9, 2025 12:48 PM
> > > To: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane at intel.com>; intel-
> > > xe at lists.freedesktop.org
> > > Subject: Re: [PATCH 9/9] drm/i915/xe3lpd: Extend WA 16023981245 for
> > > display
> > > 30.02
> > >
> > > On 07.06.2025 01:21, Dnyaneshwar Bhadane wrote:
> > > > wa_16023981245 need to be exteded for display version 30.02
> > > >
> > > > Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane at intel.com>
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > > b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > > > index 15ede7678636..e0336c79c294 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > > > @@ -1085,7 +1085,8 @@ int intel_plane_check_src_coordinates(struct
> > > intel_plane_state *plane_state)
> > > >
> > > >  		/* Wa_16023981245 */
> > > >  		if ((DISPLAY_VERx100(display) == 2000 ||
> > > > -		     DISPLAY_VERx100(display) == 3000) &&
> > > > +		     DISPLAY_VERx100(display) == 3000 ||
> > > > +		     DISPLAY_VERx100(display) == 3002) &&
> > > You can simply the check to `DISPLAY_VER(display) == 30`
> > Hi,
> > Thanks,
> > This is good idea to merge it as `DISPLAY_VER(display) == 30`. I will do in next
> revision.
> 
> We try to avoid doing that for workarounds since we don't know whether that
> will be correct for other 30.xx platforms that may show up in the future.  The
> workaround database gives very precise IP version numbers for each
> workaround so we try to just follow that, at least early on in the platform's
> lifecycle.  Several years down the road once we've moved on to later
> generations and we're relatively confident that no more 30.xx platforms are
> likely to show up, we might go back and consolidate some of the workaround
> conditions like this.
>
Thank you, Matt, 
Noted for platform early life cycle, No further changes required as of now for this condition. 

Dnyaneshwar,

> 
> Matt
> 
> >
> > Dnyaneshwar
> >
> > >
> > > Regards,
> > > Bala
> > > >  		     src_x % 2 != 0)
> > > >  			hsub = 2;
> > > >  	} else {
> > > > --
> > > > 2.34.1
> > > >
> 
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation