[PATCH 4/4] drm/xe: Drop unnecessary include from xe_tile.h
Matt Roper
matthew.d.roper at intel.com
Mon Jun 9 21:27:31 UTC 2025
On Tue, Jun 03, 2025 at 10:28:26PM +0200, Michal Wajdeczko wrote:
> We don't need to include xe_device_types.h there.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
I'm mostly relying on the compiler/CI to verify that we don't have any
other cases (aside from the one you fixed in xe_tile_sysfs.c) where the
code needed device_types and was relying on the implicit include from
xe_tile.
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
Matt
> ---
> drivers/gpu/drm/xe/xe_tile.h | 3 ++-
> drivers/gpu/drm/xe/xe_tile_sysfs.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_tile.h b/drivers/gpu/drm/xe/xe_tile.h
> index eb939316d55b..5ade71bda89a 100644
> --- a/drivers/gpu/drm/xe/xe_tile.h
> +++ b/drivers/gpu/drm/xe/xe_tile.h
> @@ -6,8 +6,9 @@
> #ifndef _XE_TILE_H_
> #define _XE_TILE_H_
>
> -#include "xe_device_types.h"
> +#include <linux/types.h>
>
> +struct xe_device;
> struct xe_tile;
>
> int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id);
> diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
> index b804234a6551..6dcac829839d 100644
> --- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
> @@ -7,8 +7,8 @@
> #include <linux/sysfs.h>
> #include <drm/drm_managed.h>
>
> +#include "xe_device_types.h"
> #include "xe_pm.h"
> -#include "xe_tile.h"
> #include "xe_tile_sysfs.h"
> #include "xe_vram_freq.h"
>
> --
> 2.47.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
More information about the Intel-xe
mailing list