✗ CI.checkpatch: warning for drm/xe: Make struct xe_ggtt private. (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 10 07:10:24 UTC 2025


== Series Details ==

Series: drm/xe: Make struct xe_ggtt private. (rev2)
URL   : https://patchwork.freedesktop.org/series/139778/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c9090dc585ff809e4a126842a0e1a44075ef5f81
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Tue Jun 10 09:02:39 2025 +0200

    drm/xe: Move struct xe_ggtt to xe_ggtt.c
    
    No users left outside of xe_ggtt.c, so we can make the struct private.
    
    This prevents us from accidentally touching it before init.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
    Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 52ecbb6a68785860c776b29f58792d9807243979 drm-intel
a774a0981fb8 drm/mm: Introduce address space shifting
c7cba73d604d drm/xe: Start using ggtt->start in preparation of balloon removal
-:91: CHECK:SPACING: No space is necessary after a cast
#91: FILE: drivers/gpu/drm/xe/xe_ggtt.c:270:
+		ggtt_size = (gsm_size / 8) * (u64) XE_PAGE_SIZE - ggtt_start;

total: 0 errors, 0 warnings, 1 checks, 146 lines checked
de4cc4e9370a drm/xe: Rewrite GGTT VF initialisation
-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#69: FILE: drivers/gpu/drm/xe/xe_ggtt.c:277:
+			drm_err(&xe->drm, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
+				     ggtt->tile->id, ggtt_start, ggtt_start + ggtt_size - 1);

-:291: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#291: 
deleted file mode 100644

total: 0 errors, 1 warnings, 1 checks, 240 lines checked
d3c27e35ba4f drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT
-:193: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#193: FILE: drivers/gpu/drm/xe/xe_ggtt.c:483:
+static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node,
 			       u32 size, u32 align, u32 mm_flags)

total: 0 errors, 0 warnings, 1 checks, 321 lines checked
c9090dc585ff drm/xe: Move struct xe_ggtt to xe_ggtt.c
-:42: ERROR:CODE_INDENT: code indent should use tabs where possible
#42: FILE: drivers/gpu/drm/xe/xe_ggtt.c:90:
+        /** @start: Start offset of GGTT */$

total: 1 errors, 0 warnings, 0 checks, 120 lines checked




More information about the Intel-xe mailing list