[PATCH v4 06/10] platform/x86/intel/pmt: correct types

Ilpo Järvinen ilpo.jarvinen at linux.intel.com
Wed Jun 11 10:46:58 UTC 2025


On Tue, 10 Jun 2025, Michael J. Ruhl wrote:

> A couple of auto variables do not match the return types of some of
> the functions.
> 
> Update the mismatched types to match.
> 
> Reviewed-by: David E. Box <david.e.box at linux.intel.com>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl at intel.com>
> ---
>  drivers/platform/x86/intel/pmt/crashlog.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
> index 3d3b72451c01..ddb05d069fc6 100644
> --- a/drivers/platform/x86/intel/pmt/crashlog.c
> +++ b/drivers/platform/x86/intel/pmt/crashlog.c
> @@ -137,7 +137,7 @@ static ssize_t
>  enable_show(struct device *dev, struct device_attribute *attr, char *buf)
>  {
>  	struct intel_pmt_entry *entry = dev_get_drvdata(dev);
> -	int enabled = !pmt_crashlog_disabled(entry);
> +	bool enabled = !pmt_crashlog_disabled(entry);
>  
>  	return sprintf(buf, "%d\n", enabled);
>  }
> @@ -168,7 +168,7 @@ static ssize_t
>  trigger_show(struct device *dev, struct device_attribute *attr, char *buf)
>  {
>  	struct intel_pmt_entry *entry;
> -	int trigger;
> +	bool trigger;
>  
>  	entry = dev_get_drvdata(dev);
>  	trigger = pmt_crashlog_complete(entry);
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen at linux.intel.com>

-- 
 i.


More information about the Intel-xe mailing list