[PATCH 1/2] drm/xe/guc: Clean up of GuC 'CTL' defines

Lucas De Marchi lucas.demarchi at intel.com
Thu Jun 12 22:01:24 UTC 2025


On Wed, Jun 11, 2025 at 02:05:52PM -0700, John.C.Harrison at Intel.com wrote:
>From: John Harrison <John.C.Harrison at Intel.com>
>
>All the field generation for the CTL defines (used for GuC init data)
>were hand-rolled rather than using FIELD_PREP/REG_GENMASK/BIT macros.
>
>Also, there were a bunch of macros defined for verbosity settings that
>were never used - it's just a number from 0 to 3, why do we need a define
>for each level!?
>
>So fix that all up.
>
>Signed-off-by: John Harrison <John.C.Harrison at Intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the Intel-xe mailing list