✗ CI.checkpatch: warning for Opportunistically skip TLB invalidaion on unbind
Patchwork
patchwork at emeril.freedesktop.org
Fri Jun 13 23:22:17 UTC 2025
== Series Details ==
Series: Opportunistically skip TLB invalidaion on unbind
URL : https://patchwork.freedesktop.org/series/150257/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 80b080aa3eb62b25e001b3580686e9b03f481775
Author: Matthew Brost <matthew.brost at intel.com>
Date: Fri Jun 13 14:02:42 2025 -0700
drm/xe: Opportunistically skip TLB invalidaion on unbind
If a range or VMA is invalidated and scratch page is disabled, there
is no reason to issue a TLB invalidation on unbind, skip TLB
innvalidation is this condition is true. This is an opportunistic check
as it is done without the notifier lock, thus it possible for the range
or VMA to be invalidated after this check is performed.
This should improve performance of the SVM garbage collector, for
example, xe_exec_system_allocator --r many-stride-new-prefetch, went
~20s to ~9.5s on a BMG.
v2:
- Use helper for valid check (Thomas)
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>>
+ /mt/dim checkpatch 4d016d6e602638e0ebc3895331224e057508c07a drm-intel
c41d972cfa04 drm/xe: Add xe_vm_has_valid_gpu_pages helper
-:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'tile' may be better as '(tile)' to avoid precedence issues
#140: FILE: drivers/gpu/drm/xe/xe_vm.h:394:
+#define xe_vm_has_valid_gpu_pages(tile, tile_present, tile_invalidated) \
+ ((READ_ONCE(tile_present) & ~READ_ONCE(tile_invalidated)) & BIT(tile->id))
total: 0 errors, 0 warnings, 1 checks, 102 lines checked
80b080aa3eb6 drm/xe: Opportunistically skip TLB invalidaion on unbind
More information about the Intel-xe
mailing list