✗ CI.checkpatch: warning for Opportunistically skip TLB invalidaion on unbind (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 16 07:12:53 UTC 2025


== Series Details ==

Series: Opportunistically skip TLB invalidaion on unbind (rev2)
URL   : https://patchwork.freedesktop.org/series/150257/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b666efe99091c74cda10d172c296943ae4693a47
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Sun Jun 15 23:30:24 2025 -0700

    drm/xe: Opportunistically skip TLB invalidaion on unbind
    
    If a range or VMA is invalidated and scratch page is disabled, there
    is no reason to issue a TLB invalidation on unbind, skip TLB
    innvalidation is this condition is true. This is an opportunistic check
    as it is done without the notifier lock, thus it possible for the range
    to be invalidated after this check is performed.
    
    This should improve performance of the SVM garbage collector, for
    example, xe_exec_system_allocator --r many-stride-new-prefetch, went
    ~20s to ~9.5s on a BMG.
    
    v2:
     - Use helper for valid check (Thomas)
    v3:
     - Avoid skipping TLB invalidation if PTEs are removed at a higher
       level than the range
     - Never skip TLB invalidations for VMA
     - Drop Himal's RB
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 3449755a2544ecd7b6b2c81bafd992596ac7a086 drm-intel
9aacf1ccf37b drm/xe: Add xe_vm_has_valid_gpu_mapping helper
-:143: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'tile' may be better as '(tile)' to avoid precedence issues
#143: FILE: drivers/gpu/drm/xe/xe_vm.h:394:
+#define xe_vm_has_valid_gpu_mapping(tile, tile_present, tile_invalidated)	\
+	((READ_ONCE(tile_present) & ~READ_ONCE(tile_invalidated)) & BIT(tile->id))

total: 0 errors, 0 warnings, 1 checks, 102 lines checked
b666efe99091 drm/xe: Opportunistically skip TLB invalidaion on unbind




More information about the Intel-xe mailing list