[PATCH v6 8/9] drm/i915/wcl: C10 phy connected to port A and B

[Kandpal, Suraj]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> Dnyaneshwar Bhadane
> Sent: Saturday, June 14, 2025 1:02 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane at intel.com>
> Subject: [PATCH v6 8/9] drm/i915/wcl: C10 phy connected to port A and B
> 
> WCL added a c10 phy connected to port B. PTL code is currently restricting c10
> to phy_a only.
> 
> PTL doesn't have a PHY connected to PORT B; as such,there will never be a
> case where PTL uses PHY B.
> WCL uses PORT A and B with the C10 PHY.Reusing the condition for WCL and
> extending it for PORT B should not cause any issues for PTL.
> 
> -v2: Reuse and extend PTL condition for WCL (Matt)

Add the bspec reference here

> 
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index 83c8df9dbc0c..ed8e640b96b0 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -39,7 +39,13 @@ bool intel_encoder_is_c10phy(struct intel_encoder
> *encoder)
>  	struct intel_display *display = to_intel_display(encoder);
>  	enum phy phy = intel_encoder_to_phy(encoder);
> 
> -	if (display->platform.pantherlake && phy == PHY_A)
> +	/* PTL doesn't have a PHY connected to PORT B; as such,
> +	 * there will never be a case where PTL uses PHY B.
> +	 * WCL uses PORT A and B with the C10 PHY.
> +	 * Reusing the condition for WCL and extending it for PORT B
> +	 * should not cause any issues for PTL.
> +	 */
> +	if (display->platform.pantherlake && phy < PHY_C)

Just because PTL does not have PHY connected to  Port B does not mean the code wont come here it seemed like this is the check
That made sure we go to c10 PHY and with this it will go for c10 phy when port becomes port B

Regards,
Suraj Kandpal
>  		return true;
> 
>  	if ((display->platform.lunarlake || display->platform.meteorlake) &&
> phy < PHY_C)
> --
> 2.34.1