✗ CI.checkpatch: warning for Use DRM scheduler for delayed GT TLB invalidations

[Patchwork]

== Series Details ==

Series: Use DRM scheduler for delayed GT TLB invalidations
URL   : https://patchwork.freedesktop.org/series/150402/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 385d724a23203d0dbddb680258a58b90f3d0581c
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Tue Jun 17 08:37:30 2025 -0700

    drm/xe: Use GT TLB invalidation jobs in PT layer
    
    Rather than open-coding GT TLB invalidations in the PT layer, use GT TLB
    invalidation jobs. The real benefit is that GT TLB invalidation jobs use
    a single dma-fence context, allowing the generated fences to be squashed
    in dma-resv/DRM scheduler.
    
    Suggested-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch cec6aa5dda0bef82c8f9ba6422d982712a0f8c7d drm-intel
a232170258a1 drm/xe: Explicitly mark migration queues with flag
57f99acd2529 drm/xe: Add generic dependecy jobs / scheduler
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 202 lines checked
aa8e8d562bd1 drm/xe: Add dependency scheduler for GT TLB invalidations to bind queues
f7fe8e4b6b99 drm/xe: Add xe_migrate_job_lock/unlock helpers
-:35: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#35: FILE: drivers/gpu/drm/xe/xe_migrate.c:1934:
+		xe_vm_assert_held(q->vm);	/* User queues VM's should be
+						   locked */

-:35: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#35: FILE: drivers/gpu/drm/xe/xe_migrate.c:1934:
+						   locked */

-:54: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#54: FILE: drivers/gpu/drm/xe/xe_migrate.c:1953:
+		xe_vm_assert_held(q->vm);	/* User queues VM's should be
+						   locked */

-:54: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#54: FILE: drivers/gpu/drm/xe/xe_migrate.c:1953:
+						   locked */

total: 0 errors, 4 warnings, 0 checks, 52 lines checked
5be64a787cd3 drm/xe: Add GT TLB invalidation jobs
-:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

-:150: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kmalloc(sizeof(*job->fence)...) over kmalloc(sizeof(struct xe_gt_tlb_invalidation_fence)...)
#150: FILE: drivers/gpu/drm/xe/xe_gt_tlb_inval_job.c:118:
+	job->fence = kmalloc(sizeof(struct xe_gt_tlb_invalidation_fence),

-:192: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#192: FILE: drivers/gpu/drm/xe/xe_gt_tlb_inval_job.c:160:
+}
+/**

-:205: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!xa_load"
#205: FILE: drivers/gpu/drm/xe/xe_gt_tlb_inval_job.c:173:
+		  xa_load(&job->dep.drm.dependencies, 0) == NULL);

-:245: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#245: FILE: drivers/gpu/drm/xe/xe_gt_tlb_inval_job.c:213:
+		dma_fence_get(fence);	/* ref released once dependency
+					   processed by scheduler */

-:245: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#245: FILE: drivers/gpu/drm/xe/xe_gt_tlb_inval_job.c:213:
+					   processed by scheduler */

total: 0 errors, 3 warnings, 3 checks, 315 lines checked
385d724a2320 drm/xe: Use GT TLB invalidation jobs in PT layer
-:198: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#198: FILE: drivers/gpu/drm/xe/xe_pt.c:2369:
+			err = PTR_ERR(ijob);;

total: 0 errors, 1 warnings, 0 checks, 313 lines checked