[PATCH v3 5/9] drm/xe: Only dump PAT when xe_hw_engines_init_early fails

[Lucas De Marchi]

On Tue, Jun 17, 2025 at 08:01:38PM +0200, Maarten Lankhorst wrote:
>After discussion with Lucas De Marchi, it turns out that is the
>specific caller requiring a dump. This allows us to cleanup
>gt_init in a bit.
>
>Signed-off-by: Maarten Lankhorst <dev at lankhorst.se>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_gt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>index 6bc793043b400..98360986df7db 100644
>--- a/drivers/gpu/drm/xe/xe_gt.c
>+++ b/drivers/gpu/drm/xe/xe_gt.c
>@@ -464,8 +464,10 @@ static int gt_fw_domain_init(struct xe_gt *gt)
> 	xe_gt_mcr_init(gt);
>
> 	err = xe_hw_engines_init_early(gt);
>-	if (err)
>+	if (err) {
>+		dump_pat_on_error(gt);
> 		goto err_force_wake;
>+	}
>
> 	err = xe_hw_engine_class_sysfs_init(gt);
> 	if (err)
>@@ -486,7 +488,6 @@ static int gt_fw_domain_init(struct xe_gt *gt)
> 	return 0;
>
> err_force_wake:
>-	dump_pat_on_error(gt);
> 	xe_force_wake_put(gt_to_fw(gt), fw_ref);
>
> 	return err;
>-- 
>2.45.2
>