✗ CI.checkpatch: warning for drm/i915/wm: reduce stack usage in skl_print_wm_changes()
Patchwork
patchwork at emeril.freedesktop.org
Fri Jun 20 11:43:40 UTC 2025
== Series Details ==
Series: drm/i915/wm: reduce stack usage in skl_print_wm_changes()
URL : https://patchwork.freedesktop.org/series/150564/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 87c3264a6eb72ed39f5468f8bc420ac876029036
Author: Arnd Bergmann <arnd at arndb.de>
Date: Fri Jun 20 13:37:45 2025 +0200
drm/i915/wm: reduce stack usage in skl_print_wm_changes()
When KMSAN is enabled, this function causes has a rather excessive stack usage:
drivers/gpu/drm/i915/display/skl_watermark.c:2977:1: error: stack frame size (1432) exceeds limit (1408) in 'skl_compute_wm' [-Werror,-Wframe-larger-than]
This is apparently all caused by the varargs calls to drm_dbg_kms(). Inlining
this into skl_compute_wm() means that any function called by skl_compute_wm()
has its own stack on top of that.
Move the worst bit into a separate function marked as noinline_for_stack to
limit that to the one code path that actually needs it.
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
+ /mt/dim checkpatch 1b4be188ae14a43b901f3005075fab3a22f77968 drm-intel
87c3264a6eb7 drm/i915/wm: reduce stack usage in skl_print_wm_changes()
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6:
When KMSAN is enabled, this function causes has a rather excessive stack usage:
total: 0 errors, 1 warnings, 0 checks, 194 lines checked
More information about the Intel-xe
mailing list