[PATCH 1/5] drm/xe: Combine PF and VF device data into union

Piotr Piórkowski piotr.piorkowski at intel.com
Wed Jun 25 15:04:56 UTC 2025


Michal Wajdeczko <michal.wajdeczko at intel.com> wrote on wto [2025-cze-24 22:09:19 +0200]:
> There is no need to keep PF and VF data fields fully separate
> since we can be only in one mode at the time. Move them into
> a anonymous union to save few bytes.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 6aca4b1a2824..962acd451734 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -406,10 +406,12 @@ struct xe_device {
>  		/** @sriov.__mode: SR-IOV mode (Don't access directly!) */
>  		enum xe_sriov_mode __mode;
>  
> -		/** @sriov.pf: PF specific data */
> -		struct xe_device_pf pf;
> -		/** @sriov.vf: VF specific data */
> -		struct xe_device_vf vf;
> +		union {
> +			/** @sriov.pf: PF specific data */
> +			struct xe_device_pf pf;
> +			/** @sriov.vf: VF specific data */
> +			struct xe_device_vf vf;
> +		};
>  

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski at intel.com>

>  		/** @sriov.wq: workqueue used by the virtualization workers */
>  		struct workqueue_struct *wq;
> -- 
> 2.47.1
> 

-- 


More information about the Intel-xe mailing list