[PATCH v4 06/11] drm/xe: Rename gt_init sub-functions

Lucas De Marchi lucas.demarchi at intel.com
Wed Jun 25 19:09:31 UTC 2025


On Thu, Jun 19, 2025 at 12:49:05PM +0200, Maarten Lankhorst wrote:
>s/gt_fw_domain_init/gt_init_with_gt_forcewake()/
>s/all_fw_domain_init/gt_init_with_all_forcewake()/
>
>Clarify that the functions are the part of gt_init() that are called
>with the respective power domains held. all_domain() of course only
>works after discovering and initialisation of force_wake on all engines,
>that's why the split is needed in the first place.
>
>Suggested-by: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Maarten Lankhorst <dev at lankhorst.se>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_gt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>index 98360986df7db..435d888a1dfc8 100644
>--- a/drivers/gpu/drm/xe/xe_gt.c
>+++ b/drivers/gpu/drm/xe/xe_gt.c
>@@ -440,7 +440,7 @@ static void dump_pat_on_error(struct xe_gt *gt)
> 	xe_pat_dump(gt, &p);
> }
>
>-static int gt_fw_domain_init(struct xe_gt *gt)
>+static int gt_init_with_gt_forcewake(struct xe_gt *gt)
> {
> 	unsigned int fw_ref;
> 	int err;
>@@ -493,7 +493,7 @@ static int gt_fw_domain_init(struct xe_gt *gt)
> 	return err;
> }
>
>-static int all_fw_domain_init(struct xe_gt *gt)
>+static int gt_init_with_all_forcewake(struct xe_gt *gt)
> {
> 	unsigned int fw_ref;
> 	int err;
>@@ -648,7 +648,7 @@ int xe_gt_init(struct xe_gt *gt)
> 	if (err)
> 		return err;
>
>-	err = gt_fw_domain_init(gt);
>+	err = gt_init_with_gt_forcewake(gt);
> 	if (err)
> 		return err;
>
>@@ -662,7 +662,7 @@ int xe_gt_init(struct xe_gt *gt)
>
> 	xe_force_wake_init_engines(gt, gt_to_fw(gt));
>
>-	err = all_fw_domain_init(gt);
>+	err = gt_init_with_all_forcewake(gt);
> 	if (err)
> 		return err;
>
>-- 
>2.45.2
>


More information about the Intel-xe mailing list