[PATCH v2 0/5] drm/xe: Create and use XE_DEVICE_WA infrastructure

[Matt Roper]

On Wed, Jun 25, 2025 at 01:07:45PM -0700, Matt Atwood wrote:
> There currently is not a way to apply and track workarounds that are
> needed ahead of GT init. This series adds a bit field to the xe_device
> structure similar to those in the GT structures to apply and track
> workarounds applied at runtime (oobs).
> 
> Device workarounds in this new infrastructure are tracked in the
> existing sysfs entries in gtX/workarounds.
> 
> Currently 15015404425 is the only workaround like this, so move it to
> using this new infrastructure.
> 
> PTL A0 is impacted by 15015404425, but only applies to Compute Die A0
> stepping. The reality of modern platforms is that we're a Multi Chip
> Package with logic spread acress multiple dies. This information not
> being readily available during PCI probe without a read makes this more
> complicated.
> 
> Apply 15015404425 to PTL unconditionally during PCI probe (and GT init).
> After GT init use the Media GT stepping to determine if we can disable
> this workaround.
> 
> v2: Change naming from SoC to device, address styling issues, update
> commit messages
> v3: rebase
> v4: fix compile issue

You've sent three different versions of this series all with "v2" in the
cover letter subject.  The patches themselves have v3 or v4, but you
have a stale cover letter subject which is confusing.

Also, please try to avoid rapid-firing new versions of a series while
it's being actively reviewed since the review comments can get lost on
the old versions.  It looks like the mistakes that required v3 and v4
resends could have been caught by simply doing a local build test before
sending so please make sure you're doing that (and running stuff like
checkpatch to catch other mistakes) up front to minimize the thrash.


Matt

> 
> Matt Atwood (5):
>   drm/xe: add xe_device_wa infrastructure
>   drm/xe: Add infrastructure for Device OOB workarounds
>   drm/xe: Move Wa_15015404425 to use the new EX_DEVICE_WA macro
>   drm/xe: extend Wa_15015404425 to apply to PTL
>   drm/xe: disable wa_15015404425 for PTL B0
> 
>  drivers/gpu/drm/xe/Makefile               | 11 +++++-
>  drivers/gpu/drm/xe/xe_device_types.h      |  9 +++++
>  drivers/gpu/drm/xe/xe_device_wa_oob.rules |  2 +
>  drivers/gpu/drm/xe/xe_gen_wa_oob.c        | 27 +++++++++----
>  drivers/gpu/drm/xe/xe_mmio.c              | 10 ++---
>  drivers/gpu/drm/xe/xe_pci.c               | 11 ++++++
>  drivers/gpu/drm/xe/xe_rtp.c               |  5 +++
>  drivers/gpu/drm/xe/xe_rtp.h               |  3 +-
>  drivers/gpu/drm/xe/xe_rtp_types.h         |  2 +
>  drivers/gpu/drm/xe/xe_wa.c                | 46 +++++++++++++++++++++++
>  drivers/gpu/drm/xe/xe_wa.h                | 18 +++++++--
>  drivers/gpu/drm/xe/xe_wa_oob.rules        |  1 +
>  12 files changed, 127 insertions(+), 18 deletions(-)
>  create mode 100644 drivers/gpu/drm/xe/xe_device_wa_oob.rules
> 
> -- 
> 2.49.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation