[PATCH] drm/i915/display: drop a number of dependencies on i915_drv.h

Luca Coelho luca at coelho.fi
Thu Jun 26 11:21:07 UTC 2025


On Thu, 2025-06-26 at 13:16 +0300, Jani Nikula wrote:
> With the switch to an unordered workqueue dedicated to display, we've
> stopped using struct drm_i915_private in a number of places, and can
> drop the dependencies on i915_drv.h.
> 
> Cc: Luca Coelho <luciano.coelho at intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---

Nice! I had removed some of these, but apparently I forgot and lost
those changes.

[...]

> @@ -32,7 +31,7 @@ void intel_encoder_link_check_flush_work(struct intel_encoder *encoder)
>  
>  void intel_encoder_link_check_queue_work(struct intel_encoder *encoder, int delay_ms)
>  {
> -	struct intel_display *display = to_i915(encoder->base.dev)->display;
> +	struct intel_display *display = to_intel_display(encoder);
>  
>  	mod_delayed_work(display->wq.unordered,
>  			 &encoder->link_check_work, msecs_to_jiffies(delay_ms));

This looks much nicer.  I should have looked more for a better macro.

Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

--
Cheers,
Luca.


More information about the Intel-xe mailing list