[PATCH] drm/xe: remove redundant check in xe_vm_create_ioctl()

Upadhyay, Tejas tejas.upadhyay at intel.com
Mon Mar 3 06:03:00 UTC 2025



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Xin
> Wang
> Sent: Monday, March 3, 2025 6:20 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Wang, X <x.wang at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>
> Subject: [PATCH] drm/xe: remove redundant check in xe_vm_create_ioctl()
> 
> The check for args->extensions is repeated twice in xe_vm_create_ioctl().
> This commit removes the redundant check to streamline the code.

Fixes tag?

> 
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Xin Wang <x.wang at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index
> 996000f2424e..eb76f6854b2f 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1798,9 +1798,6 @@ int xe_vm_create_ioctl(struct drm_device *dev,
> void *data,
>  			 args->flags &
> DRM_XE_VM_CREATE_FLAG_FAULT_MODE))
>  		return -EINVAL;
> 
> -	if (XE_IOCTL_DBG(xe, args->extensions))
> -		return -EINVAL;
> -

LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

>  	if (args->flags & DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE)
>  		flags |= XE_VM_FLAG_SCRATCH_PAGE;
>  	if (args->flags & DRM_XE_VM_CREATE_FLAG_LR_MODE)
> --
> 2.43.0



More information about the Intel-xe mailing list