✗ CI.checkpatch: warning for Support different GuCs per GT

[Patchwork]

== Series Details ==

Series: Support different GuCs per GT
URL   : https://patchwork.freedesktop.org/series/145740/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 981d09028782604f3b3e14170796171f7759cdfa
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Mon Mar 3 11:52:15 2025 -0800

    drm/xe/ptl: Define HuC FW version for PTL
    
    First HuC release for PTL. Note that the HuC team now only releases
    GSC-enabled blobs, so we don't need the "_gsc" postfix to identify
    the variant anymore. The driver can identify the type of binary at
    runtime no matter the name.
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Signed-off-by: Matt Atwood <matthew.s.atwood at intel.com>
    Acked-by: Lucas De Marchi <lucas.demarchi at intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20241011163612.6558-1-matthew.s.atwood@intel.com
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch c55ef90b69d314c38a69d1e4b6caf1645ed5d53f drm-intel
05c20d8b644e Revert "drm/xe/ptl: Define HuC FW version for PTL"
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 7 lines checked
df500fcf0e27 Revert "drm/xe/ptl: Add GuC firmware definition"
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 7 lines checked
82e7dd88c70c Revert "drm/xe/pvc: Add GuC firmware definition"
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 7 lines checked
5d22acebc23f drm/xe/uc: Add support for different firmware files on each GT
-:68: WARNING:MACRO_ARG_UNUSED: Argument 'b' is not used in function-like macro
#68: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:142:
+#define fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	MAKE_FW_PATH(dir_, uc_, shortname_, t, "_" __stringify(a))

-:68: WARNING:MACRO_ARG_UNUSED: Argument 'c' is not used in function-like macro
#68: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:142:
+#define fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	MAKE_FW_PATH(dir_, uc_, shortname_, t, "_" __stringify(a))

-:84: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#84: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:149:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:84: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#84: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:149:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:84: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#84: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:149:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:84: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#84: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:149:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:87: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#87: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:87: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#87: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:87: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#87: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:87: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#87: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

total: 0 errors, 2 warnings, 8 checks, 106 lines checked
8a1ca25e2e60 drm/xe/pvc: Add GuC firmware definition
978e1c453031 drm/xe/ptl: Add GuC firmware definition
981d09028782 drm/xe/ptl: Define HuC FW version for PTL