✗ CI.checkpatch: warning for Allow scratch page under fault mode for certain platform (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Tue Mar 4 06:01:12 UTC 2025
== Series Details ==
Series: Allow scratch page under fault mode for certain platform (rev3)
URL : https://patchwork.freedesktop.org/series/145539/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 66ef8ea9cbd527df3100a12f91e1c15d53dea693
Author: Oak Zeng <oak.zeng at intel.com>
Date: Fri Feb 28 10:30:58 2025 -0500
drm/xe: Allow scratch page under fault mode for certain platform
Normally scratch page is not allowed when a vm is operate under page
fault mode, i.e., in the existing codes, DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE
and DRM_XE_VM_CREATE_FLAG_FAULT_MODE are mutual exclusive. The reason
is fault mode relies on recoverable page to work, while scratch page
can mute recoverable page fault.
On xe2 and xe3, out of bound prefetch can cause page fault and further
system hang because xekmd can't resolve such page fault. SYCL and OCL
language runtime requires out of bound prefetch to be silently dropped
without causing any functional problem, thus the existing behavior
doesn't meet language runtime requirement.
At the same time, HW prefetching can cause page fault interrupt. Due to
page fault interrupt overhead (i.e., need Guc and KMD involved to fix
the page fault), HW prefetching can be slowed by many orders of magnitude.
Fix those problems by allowing scratch page under fault mode for xe2 and
xe3. With scratch page in place, HW prefetching could always hit scratch
page instead of causing interrupt.
A side effect is, scratch page could hide application program error.
Application out of bound accesses are hided by scratch page mapping,
instead of get reported to user.
v2: Refine commit message (Thomas)
v3: Move the scratch page flag check to after scratch page wa (Thomas)
v4: drop NEEDS_SCRATCH macro (matt)
Add a comment to DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE
Signed-off-by: Oak Zeng <oak.zeng at intel.com>
+ /mt/dim checkpatch 1cf56e26a93292ca26fbf891368b75a67e8700dc drm-intel
f236b799a76f drm/xe: Introduced needs_scratch bit in device descriptor
2064667ee3f4 drm/xe: Clear scratch page on vm_bind
-:41: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#41:
v7: No need to check platform needs_scratch deciding invalidate_on_bind (Matt)
total: 0 errors, 1 warnings, 0 checks, 290 lines checked
66ef8ea9cbd5 drm/xe: Allow scratch page under fault mode for certain platform
More information about the Intel-xe
mailing list