[PATCH 2/2] drm/xe/pm: Re-enable D3Cold by default on BMG
Rodrigo Vivi
rodrigo.vivi at intel.com
Thu Mar 6 21:36:15 UTC 2025
This patch re-enables D3Cold by default on BMG.
If issues on runtime_pm resume are seen and the D3cold->D0 transition
is suspected to block the device or cause memory corruptions, D3cold
can be disabled for confirmation with either:
1. at runtime:
echo 0 > /sys/bus/pci/devices/<addr>/vram_d3cold_threshold
2. at boot:
pcie_port_pm=off
Upon confirmation of D3Cold related bug, please file a bug to the
link below.
Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/xe_pm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index a9f61a5fc971..12200be7b43d 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -287,7 +287,6 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
*/
int xe_pm_init(struct xe_device *xe)
{
- u32 vram_threshold;
int err;
/* For now suspend/resume is only allowed with GuC */
@@ -301,11 +300,7 @@ int xe_pm_init(struct xe_device *xe)
if (err)
return err;
- /* FIXME: D3Cold temporarily disabled by default on BMG */
- vram_threshold = xe->info.platform == XE_BATTLEMAGE ? 0 :
- DEFAULT_VRAM_THRESHOLD;
-
- err = xe_pm_set_vram_threshold(xe, vram_threshold);
+ err = xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
if (err)
return err;
}
--
2.48.1
More information about the Intel-xe
mailing list