✗ CI.checkpatch: warning for drm/xe/rtp: Drop sentinel from xe_rtp_process_to_sr() (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe/rtp: Drop sentinel from xe_rtp_process_to_sr() (rev2)
URL   : https://patchwork.freedesktop.org/series/145960/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
cbb4e4a079d89106c2736adc3c7de6f9dc56da07
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 548127ed6209654cdc244cba51216297f50a84c8
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Thu Mar 6 20:00:05 2025 -0800

    drm/xe/rtp: Drop sentinels from arg to xe_rtp_process_to_sr()
    
    There's a mismatch on API: while xe_rtp_process_to_sr() processes
    entries until an entry without name, the active tracking with
    xe_rtp_process_ctx_enable_active_tracking() needs to use the number of
    elements. The number of elements is taken everywhere using ARRAY_SIZE(),
    but that will have one entry too many. This leads to the following
    warning, as reported by lkp:
    
       drivers/gpu/drm/xe/xe_tuning.c: In function 'xe_tuning_dump':
    >> include/drm/drm_print.h:228:31: warning: '%s' directive argument is null [-Wformat-overflow=]
         228 |         drm_printf((printer), "%.*s" fmt, (indent), "\t\t\t\t\tX", ##__VA_ARGS__)
             |                               ^~~~~~
       drivers/gpu/drm/xe/xe_tuning.c:226:17: note: in expansion of macro 'drm_printf_indent'
         226 |                 drm_printf_indent(p, 1, "%s\n", engine_tunings[idx].name);
             |                 ^~~~~~~~~~~~~~~~~
    
    That's because it will still process the last entry when tracking the
    active tunings. The same issue exists in the WAs. Change
    xe_rtp_process_to_sr() to also take the number of elements so the empty
    entry can be removed and the warning should go away. Fixing on the
    active-tracking side would more fragile as the it would need a `- 1`
    everywhere and continue to use a different approach for number of
    elements.
    
    Aside from the warning, it's a non-issue as there would always be enough
    bits allocated and the last entry would never be active since
    xe_rtp_process_to_sr() stops on the sentinel.
    
    Reported-by: kernel test robot <lkp at intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202503021906.P2MwAvyK-lkp@intel.com/
    Cc: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch f02ab9f6e182046bd0df9b5e50e968bd57ed290f drm-intel
548127ed6209 drm/xe/rtp: Drop sentinels from arg to xe_rtp_process_to_sr()
-:14: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14: 
>> include/drm/drm_print.h:228:31: warning: '%s' directive argument is null [-Wformat-overflow=]

total: 0 errors, 1 warnings, 0 checks, 174 lines checked