[PATCH] drm/xe: Release gud ids before cancelling work

Upadhyay, Tejas tejas.upadhyay at intel.com
Fri Mar 7 08:22:42 UTC 2025



> -----Original Message-----
> From: De Marchi, Lucas <lucas.demarchi at intel.com>
> Sent: Friday, March 7, 2025 1:43 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> Cc: Brost, Matthew <matthew.brost at intel.com>; intel-
> xe at lists.freedesktop.org
> Subject: Re: [PATCH] drm/xe: Release gud ids before cancelling work
> 
> On Fri, Mar 07, 2025 at 06:03:53AM +0000, Upadhyay, Tejas wrote:
> >
> >
> >> -----Original Message-----
> >> From: Brost, Matthew <matthew.brost at intel.com>
> >> Sent: Friday, March 7, 2025 11:32 AM
> >> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> >> Cc: intel-xe at lists.freedesktop.org
> >> Subject: Re: [PATCH] drm/xe: Release gud ids before cancelling work
> >>
> >> On Thu, Mar 06, 2025 at 06:42:11PM +0530, Tejas Upadhyay wrote:
> >> > A GT resets can be occurring in parallel while cancelling work in
> >> > async call  which can requeue these workers.
> >> > to avoid that, lets first release guc ids and then cancel work so
> >> > they don't requeued.
> >> >
> >>
> >> Suggested-by: Matthew Brost <matthew.brost at intel.com>
> >>
> >> > Fixes: 8ae8a2e8dd21 ("drm/xe: Long running job update")
> >> > Fixes: 18fbd567e75f ("drm/xe: cancel pending job timer before
> >> > freeing
> >> > scheduler")
> >> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> >>
> >> Were you able to verify this fixes [1]?
> >
> >It is not reproduced with or without fix, Ran 1000s iterations of whole
> testsuit on BMG as well as on LNL manually through scripting. May be CI can
> test it better.
> 
> I fixed the typo in the subject (s/gud/guc/) and applied to drm-xe-next.

Thanks for correcting s/gud/guc/ and applying.

Tejas
> 
> Thanks
> Lucas De Marchi


More information about the Intel-xe mailing list