✗ CI.checkpatch: warning for drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 10 17:45:33 UTC 2025


== Series Details ==

Series: drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl (rev2)
URL   : https://patchwork.freedesktop.org/series/146024/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
cbb4e4a079d89106c2736adc3c7de6f9dc56da07
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e4dab6ae784b64a2e8d892ce154a1ee5ac4f23bf
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Mon Mar 10 17:18:34 2025 +0000

    drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl
    
    Add support for userspace to request a list of observed failed
    pagefaults from a specified VM.
    
    v2:
    - Only allow querying of failed pagefaults (Matt Brost)
    
    v3:
    - Remove unnecessary size parameter from helper function, as it
      is a property of the arguments. (jcavitt)
    - Remove unnecessary copy_from_user (Jainxun)
    - Set address_precision to 1 (Jainxun)
    - Report max size instead of dynamic size for memory allocation
      purposes.  Total memory usage is reported separately.
    
    v4:
    - Return int from xe_vm_get_property_size (Shuicheng)
    - Fix memory leak (Shuicheng)
    - Remove unnecessary size variable (jcavitt)
    
    v5:
    - Rename ioctl to xe_vm_get_faults_ioctl (jcavitt)
    - Update fill_property_pfs to eliminate need for kzalloc (Jianxun)
    
    v6:
    - Repair and move fill_faults break condition (Dan Carpenter)
    - Free vm after use (jcavitt)
    - Combine assertions (jcavitt)
    - Expand size check in xe_vm_get_faults_ioctl (jcavitt)
    - Remove return mask from fill_faults, as return is already -EFAULT or 0
      (jcavitt)
    
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
    Suggested-by: Matthew Brost <matthew.brost at intel.com>
    CC: Jainxun Zhang <jianxun.zhang at intel.com>
    CC: Shuicheng Lin <shuicheng.lin at intel.com>
+ /mt/dim checkpatch 939e7a162757dcb256c69af62f0f81aa4fd7d8d1 drm-intel
fadc0848cb24 drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs
f650aac3ea2c drm/xe/xe_gt_pagefault: Migrate pagefault struct to header
fc25372583d1 drm/xe/xe_vm: Add per VM pagefault info
ad1b725f2c77 drm/xe/uapi: Define drm_xe_vm_get_faults
-:34: WARNING:LONG_LINE: line length of 126 exceeds 100 columns
#34: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_VM_GET_FAULTS		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_GET_FAULTS, struct drm_xe_vm_get_faults)

total: 0 errors, 1 warnings, 0 checks, 73 lines checked
479eabcb91fc drm/xe/xe_gt_pagefault: Add address_type field to pagefaults
e4dab6ae784b drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl




More information about the Intel-xe mailing list