✗ CI.checkpatch: warning for drm/xe/pmu: Add GT frequency events (rev5)

[Patchwork]

== Series Details ==

Series: drm/xe/pmu: Add GT frequency events (rev5)
URL   : https://patchwork.freedesktop.org/series/144164/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
cbb4e4a079d89106c2736adc3c7de6f9dc56da07
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a2730a941cd299378f8429409d07712632c35ef1
Author: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Date:   Tue Mar 11 17:14:08 2025 -0700

    drm/xe/pmu: Add GT frequency events
    
    Define PMU events for GT frequency (actual and requested). This is
    a port from the i915 driver implementation, where an internal timer
    is used to aggregate GT frequencies over certain fixed interval.
    Following PMU events are being added-
    
      xe_0000_00_02.0/gt-actual-frequency/              [Kernel PMU event]
      xe_0000_00_02.0/gt-requested-frequency/           [Kernel PMU event]
    
    Standard perf commands can be used to monitor GT frequency-
      $ perf stat -e xe_0000_00_02.0/gt-requested-frequency,gt=0/ -I1000
    
         1.001175175                700 M    xe/gt-requested-frequency,gt=0/
         2.005891881                703 M    xe/gt-requested-frequency,gt=0/
         3.007318169                700 M    xe/gt-requested-frequency,gt=0/
    
    Actual frequencies will be reported as 0 when GT is in C6.
    
    v2: Use locks while storing/reading samples, keep track of multiple
    clients (Lucas) and other general cleanup.
    v3: Review comments (Lucas) and use event counts instead of mask for
    active events.
    
    Cc: Riana Tauro <riana.tauro at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
+ /mt/dim checkpatch eb17816e52395a403aa0b447aa0befa9d2f86dd5 drm-intel
a2730a941cd2 drm/xe/pmu: Add GT frequency events
-:116: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#116: FILE: drivers/gpu/drm/xe/xe_pmu.c:265:
+		    uint32_t val, uint32_t period)

-:183: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#183: FILE: drivers/gpu/drm/xe/xe_pmu.c:356:
+	uint32_t act_freq, cur_freq;

-:236: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#236: FILE: drivers/gpu/drm/xe/xe_pmu.c:409:
+	uint32_t id = config_to_event_id(event->attr.config);

-:270: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#270: FILE: drivers/gpu/drm/xe/xe_pmu.c:447:
+	uint32_t id = config_to_event_id(event->attr.config);

-:312: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#312: FILE: drivers/gpu/drm/xe/xe_pmu.c:564:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                        ^

-:312: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#312: FILE: drivers/gpu/drm/xe/xe_pmu.c:564:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                               ^

-:314: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#314: FILE: drivers/gpu/drm/xe/xe_pmu.c:566:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                        ^

-:314: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#314: FILE: drivers/gpu/drm/xe/xe_pmu.c:566:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                                  ^

total: 0 errors, 0 warnings, 8 checks, 349 lines checked