[PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

Lucas De Marchi lucas.demarchi at intel.com
Wed Mar 12 16:41:17 UTC 2025


On Wed, Mar 12, 2025 at 01:25:28PM +0200, Jani Nikula wrote:
>On Wed, 12 Mar 2025, "Nautiyal, Ankit K" <ankit.k.nautiyal at intel.com> wrote:
>> On 3/11/2025 11:38 PM, Jani Nikula wrote:
>>> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal at intel.com> wrote:
>>>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>>
>>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
>>>> ---
>>>>   drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> index 717286981687..332647c4ca81 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>>   	func(supports_tv);
>>>>
>>>>   #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>>> +#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>>>   #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
>>> Y comes before _ in asciibetical order.
>>
>> Thanks for pointing this out. I had a misconception that we use _ as
>> delimiter and sort the words in alphabetical order.
>
>Emacs M-x sort-lines is the definition for me. ;)

`LANG=C sort -u` and it works in vim and anywhere else :).  -u because
we also don't want duplicate lines.

Lucas De Marchi


More information about the Intel-xe mailing list