[PATCH v4 0/3] drm/xe: Fix survivability
Lucas De Marchi
lucas.demarchi at intel.com
Thu Mar 13 20:40:58 UTC 2025
It turns out commit d40f275d96e8 ("drm/xe: Move survivability entirely
to xe_pci") did a bad job moving things to xe_pci. The fix provided by
Riana in 20250306055407.511405-1-riana.tauro at intel.com fixes it
partially, but injecting a failure in xe_pcode_probe_early still causes
the kernel to give warnings/errors.
Correct the course and better split what is done in xe_pci vs xe_device.
This time, also add a patch to test we can handle errors in
xe_pcode_probe_early() and other early probe functions.
Entering survivability mode was tested with an additional one line to
change the return of xe_survivability_mode_requested(). If we want to
inject error, we'd need to change it's return type, but there's also
another patch series to force it via configs, so this doesn't seem very
important right now.
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
Changes in v4:
- Minor change in 1st patch, no change in behavior
- Link to v3: https://lore.kernel.org/r/20250312-fix-survivability-v3-0-54620dbcbbd7@intel.com
Changes in v3:
- Add another fix for heci
- Rename function according to review feedback
- Link to v2: https://lore.kernel.org/r/20250311-fix-survivability-v2-0-729ce081155e@intel.com
Changes in v2:
- Cover more error injections in the second patch
- Link to v1: https://lore.kernel.org/r/20250310-fix-survivability-v1-0-7af31432bbd0@intel.com
---
Lucas De Marchi (3):
drm/xe: Move survivability back to xe
drm/xe: Set survivability mode before heci init
drm/xe: Allow to inject error in early probe
drivers/gpu/drm/xe/xe_device.c | 18 ++++++++++++++++--
drivers/gpu/drm/xe/xe_mmio.c | 1 +
drivers/gpu/drm/xe/xe_pci.c | 16 +++++++---------
drivers/gpu/drm/xe/xe_pcode.c | 2 ++
drivers/gpu/drm/xe/xe_survivability_mode.c | 29 +++++++++++++++++++++--------
drivers/gpu/drm/xe/xe_survivability_mode.h | 1 -
6 files changed, 47 insertions(+), 20 deletions(-)
---
base-commit: 7e32e5705a5c8398e606a23eeba751a059a0b970
change-id: 20250310-fix-survivability-703246c0c480
Best regards,
--
Lucas De Marchi <lucas.demarchi at intel.com>
More information about the Intel-xe
mailing list