✗ CI.checkpatch: warning for drm/xe/xe_vm: Implement xe_vm_get_property_ioctl (rev9)

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 13 22:12:20 UTC 2025


== Series Details ==

Series: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl (rev9)
URL   : https://patchwork.freedesktop.org/series/145529/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
cbb4e4a079d89106c2736adc3c7de6f9dc56da07
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5a0289c4e5ca49d20e1fced46dd8340a63ec3c98
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Thu Mar 13 18:34:08 2025 +0000

    drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
    
    Add support for userspace to request a list of observed faults
    from a specified VM.
    
    v2:
    - Only allow querying of failed pagefaults (Matt Brost)
    
    v3:
    - Remove unnecessary size parameter from helper function, as it
      is a property of the arguments. (jcavitt)
    - Remove unnecessary copy_from_user (Jainxun)
    - Set address_precision to 1 (Jainxun)
    - Report max size instead of dynamic size for memory allocation
      purposes.  Total memory usage is reported separately.
    
    v4:
    - Return int from xe_vm_get_property_size (Shuicheng)
    - Fix memory leak (Shuicheng)
    - Remove unnecessary size variable (jcavitt)
    
    v5:
    - Rename ioctl to xe_vm_get_faults_ioctl (jcavitt)
    - Update fill_property_pfs to eliminate need for kzalloc (Jianxun)
    
    v6:
    - Repair and move fill_faults break condition (Dan Carpenter)
    - Free vm after use (jcavitt)
    - Combine assertions (jcavitt)
    - Expand size check in xe_vm_get_faults_ioctl (jcavitt)
    - Remove return mask from fill_faults, as return is already -EFAULT or 0
      (jcavitt)
    
    v7:
    - Revert back to using xe_vm_get_property_ioctl
    - Apply better copy_to_user logic (jcavitt)
    
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
    Suggested-by: Matthew Brost <matthew.brost at intel.com>
    Cc: Jainxun Zhang <jianxun.zhang at intel.com>
    Cc: Shuicheng Lin <shuicheng.lin at intel.com>
+ /mt/dim checkpatch d7e9873f7923d139bdd258f4061751b5bfae468f drm-intel
c6f1f2df0aef drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs
d2c670df01c2 drm/xe/xe_gt_pagefault: Move pagefault struct to header
-:130: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#130: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 159 lines checked
d9649a32af5d drm/xe/uapi: Define drm_xe_vm_get_property
-:34: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#34: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_VM_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_GET_PROPERTY, struct drm_xe_vm_get_property)

total: 0 errors, 1 warnings, 0 checks, 93 lines checked
9c2996a78e05 drm/xe/xe_gt_pagefault: Add address_type field to pagefaults
5df38095bba7 drm/xe/xe_vm: Add per VM fault info
-:111: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#111: FILE: drivers/gpu/drm/xe/xe_vm.c:802:
+	if (!e) {
+		drm_warn(&vm->xe->drm,

total: 0 errors, 1 warnings, 0 checks, 187 lines checked
5a0289c4e5ca drm/xe/xe_vm: Implement xe_vm_get_property_ioctl




More information about the Intel-xe mailing list