[PATCH] drm/xe/xe_gt_pagefault: Remove pagefault vfid
Jonathan Cavitt
jonathan.cavitt at intel.com
Mon Mar 17 15:26:56 UTC 2025
The VFID will always be zero according to the GuC ABI, at least with
respect to pagefault reporting. So, stop storing and reporting it.
Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
CC: Matt Brost <matthew.brost at intel.com>
CC: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/xe_gt_pagefault.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
index 9fa11e837dd1..debc260cd679 100644
--- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
@@ -27,7 +27,6 @@ struct pagefault {
u64 page_addr;
u32 asid;
u16 pdata;
- u8 vfid;
u8 access_type;
u8 fault_type;
u8 fault_level;
@@ -269,7 +268,6 @@ static int send_pagefault_reply(struct xe_guc *guc,
static void print_pagefault(struct xe_device *xe, struct pagefault *pf)
{
drm_dbg(&xe->drm, "\n\tASID: %d\n"
- "\tVFID: %d\n"
"\tPDATA: 0x%04x\n"
"\tFaulted Address: 0x%08x%08x\n"
"\tFaultType: %d\n"
@@ -277,7 +275,7 @@ static void print_pagefault(struct xe_device *xe, struct pagefault *pf)
"\tFaultLevel: %d\n"
"\tEngineClass: %d %s\n"
"\tEngineInstance: %d\n",
- pf->asid, pf->vfid, pf->pdata, upper_32_bits(pf->page_addr),
+ pf->asid, pf->pdata, upper_32_bits(pf->page_addr),
lower_32_bits(pf->page_addr),
pf->fault_type, pf->access_type, pf->fault_level,
pf->engine_class, xe_hw_engine_class_to_str(pf->engine_class),
@@ -304,7 +302,6 @@ static bool get_pagefault(struct pf_queue *pf_queue, struct pagefault *pf)
PFD_PDATA_HI_SHIFT;
pf->pdata |= FIELD_GET(PFD_PDATA_LO, desc->dw0);
pf->asid = FIELD_GET(PFD_ASID, desc->dw1);
- pf->vfid = FIELD_GET(PFD_VFID, desc->dw2);
pf->access_type = FIELD_GET(PFD_ACCESS_TYPE, desc->dw2);
pf->fault_type = FIELD_GET(PFD_FAULT_TYPE, desc->dw2);
pf->page_addr = (u64)(FIELD_GET(PFD_VIRTUAL_ADDR_HI, desc->dw3)) <<
@@ -393,8 +390,7 @@ static void pf_queue_work_func(struct work_struct *w)
FIELD_PREP(PFR_DESC_TYPE, FAULT_RESPONSE_DESC) |
FIELD_PREP(PFR_ASID, pf.asid);
- reply.dw1 = FIELD_PREP(PFR_VFID, pf.vfid) |
- FIELD_PREP(PFR_ENG_INSTANCE, pf.engine_instance) |
+ reply.dw1 = FIELD_PREP(PFR_ENG_INSTANCE, pf.engine_instance) |
FIELD_PREP(PFR_ENG_CLASS, pf.engine_class) |
FIELD_PREP(PFR_PDATA, pf.pdata);
--
2.43.0
More information about the Intel-xe
mailing list