✗ CI.checkpatch: warning for drm/xe/xe_vm: Implement xe_vm_get_property_ioctl (rev10)

[Patchwork]

== Series Details ==

Series: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl (rev10)
URL   : https://patchwork.freedesktop.org/series/145529/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://github.com/intel-lgci-fdo-gitlab-mirror/drm.maintainer-tools mt
Cloning into 'mt'...
+ git -C mt rev-list -n1 origin/master
cbb4e4a079d89106c2736adc3c7de6f9dc56da07
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 49a17d15263b36a63200ab6b318ecb6f47605a9c
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Tue Mar 18 17:11:33 2025 +0000

    drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
    
    Add support for userspace to request a list of observed faults
    from a specified VM.
    
    v2:
    - Only allow querying of failed pagefaults (Matt Brost)
    
    v3:
    - Remove unnecessary size parameter from helper function, as it
      is a property of the arguments. (jcavitt)
    - Remove unnecessary copy_from_user (Jainxun)
    - Set address_precision to 1 (Jainxun)
    - Report max size instead of dynamic size for memory allocation
      purposes.  Total memory usage is reported separately.
    
    v4:
    - Return int from xe_vm_get_property_size (Shuicheng)
    - Fix memory leak (Shuicheng)
    - Remove unnecessary size variable (jcavitt)
    
    v5:
    - Rename ioctl to xe_vm_get_faults_ioctl (jcavitt)
    - Update fill_property_pfs to eliminate need for kzalloc (Jianxun)
    
    v6:
    - Repair and move fill_faults break condition (Dan Carpenter)
    - Free vm after use (jcavitt)
    - Combine assertions (jcavitt)
    - Expand size check in xe_vm_get_faults_ioctl (jcavitt)
    - Remove return mask from fill_faults, as return is already -EFAULT or 0
      (jcavitt)
    
    v7:
    - Revert back to using xe_vm_get_property_ioctl
    - Apply better copy_to_user logic (jcavitt)
    
    v8:
    - Fix and clean up error value handling in ioctl (jcavitt)
    - Reapply return mask for fill_faults (jcavitt)
    
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
    Suggested-by: Matthew Brost <matthew.brost at intel.com>
    Cc: Jainxun Zhang <jianxun.zhang at intel.com>
    Cc: Shuicheng Lin <shuicheng.lin at intel.com>
+ /mt/dim checkpatch a958e31a81b3267201c85b6f171419586afa792c drm-intel
9e40d8dd5d4e drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs
808a8ce89929 drm/xe/xe_gt_pagefault: Move pagefault struct to header
-:131: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#131: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 152 lines checked
197a27e79da9 drm/xe/uapi: Define drm_xe_vm_get_property
-:38: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#38: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_VM_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_GET_PROPERTY, struct drm_xe_vm_get_property)

total: 0 errors, 1 warnings, 0 checks, 104 lines checked
3d2cb04bf3e2 drm/xe/xe_gt_pagefault: Add address_type field to pagefaults
b43a62fe9cb4 drm/xe/xe_vm: Add per VM fault info
-:119: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#119: FILE: drivers/gpu/drm/xe/xe_vm.c:803:
+	if (!e) {
+		drm_warn(&vm->xe->drm,

total: 0 errors, 1 warnings, 0 checks, 194 lines checked
49a17d15263b drm/xe/xe_vm: Implement xe_vm_get_property_ioctl