[PATCH -next] drm/xe: Fix unmet direct dependencies warning
Lucas De Marchi
lucas.demarchi at intel.com
Sat Mar 22 12:51:23 UTC 2025
On Sat, Mar 22, 2025 at 05:55:21PM +0800, Yue Haibing wrote:
>WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
> Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
> Selected by [m]:
> - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y]
>
>FB_IOMEM_HELPERS depends on FB_CORE, Select it before FB_IOMEM_HELPERS.
>
>Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
>Signed-off-by: Yue Haibing <yuehaibing at huawei.com>
>---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>index 7d7995196702..fcf324f37d2d 100644
>--- a/drivers/gpu/drm/xe/Kconfig
>+++ b/drivers/gpu/drm/xe/Kconfig
>@@ -53,6 +53,7 @@ config DRM_XE
> config DRM_XE_DISPLAY
> bool "Enable display support"
> depends on DRM_XE && DRM_XE=m && HAS_IOPORT
>+ select FB_CORE
other places in drm, including i915 where this is coming from, use:
select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION
... and don't explicitly select FB_CORE. I think that is sufficient
following the chain of selects which ends up with DRM_CLIENT_LIB
selecting FB_CORE when DRM_FBDEV_EMULATION is set. Does that fixes it
for you?
Lucas De Marchi
More information about the Intel-xe
mailing list