✗ CI.checkpatch: warning for series starting with [1/2] drm/xe: Remove extra spaces in xe_vm.c (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Tue Mar 25 08:55:18 UTC 2025
== Series Details ==
Series: series starting with [1/2] drm/xe: Remove extra spaces in xe_vm.c (rev2)
URL : https://patchwork.freedesktop.org/series/146562/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
99e5a866b5e13f134e606a3e29d9508d97826fb3
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit aed5ae88240826e26cf286a8c3abdd2e561fdefb
Author: Maarten Lankhorst <dev at lankhorst.se>
Date: Tue Mar 25 09:10:43 2025 +0100
drm/xe: Copy cpu_caching when importing DMA-BUF.
Hey,
On 2025-03-21 11:23, Thomas Hellström wrote:
> Hi, Maarten.
>
> On Thu, 2025-03-20 at 22:15 +0100, Maarten Lankhorst wrote:
>> When testing xe with P2PDMA DMA-BUF import,
>> VM_BIND was failing because cpu_caching was not set.
>>
>> Set cpu_caching if available from another xe driver,
>> to allow uncached VM_BIND on imported DMA-BUF.
>>
>> Signed-off-by: Maarten Lankhorst <dev at lankhorst.se>
>
> I don't think this is correct, we shouldn't assume anything about
> imported dma-bufs, really. If we do we might end up in a situation
> where code works for dma-bufs imported from one device but not from
> another.
>
> I think what we can do is to relax the COH mode check. It only really
> matters on IGPU. On DGPU, all accesses to system memory is coherent.
>
> Next step would perhaps be to assume that on p2p access, a dma-buf is
> coherently cleared when all KERNEL dma-fences are signaled, but that
> would require a cross-driver agreement, so in essence allow non-
> coherent VM_BIND to device memory. This would matter only for IGPU
> mapping a device p2p.
>
> /Thomas
So would something like this work instead?
----8<----
+ /mt/dim checkpatch c217ee2fc8a5267fa66276423f3f27867480c98e drm-intel
53c605e25d99 drm/xe: Remove extra spaces in xe_vm.c
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
aed5ae882408 drm/xe: Copy cpu_caching when importing DMA-BUF.
-:62: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 0 checks, 15 lines checked
More information about the Intel-xe
mailing list