[PATCH] drm/xe/guc: Reformat dead CT reason string to be devcoredump compatible

[Lucas De Marchi]

On Tue, Mar 25, 2025 at 01:31:11PM -0700, John.C.Harrison at Intel.com wrote:
>From: John Harrison <John.C.Harrison at Intel.com>
>
>The dump on a dead CT tries to emulate the devcoredump formatting (it
>would use devcoredump code directly but that requires more re-work to
>happen - work in progress). So update the print of the dead CT reason
>code to match the format of the 'reason' string that was added to the
>actual devcoredump a little while ago.
>
>Signed-off-by: John Harrison <John.C.Harrison at Intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

I stumbled upon this a couple of times and wondered why ct_dead_print()
is "emulating" a "**** Xe Device Coredump ****". Maybe that should be
delegated to xe_devcoredump only and allow xe_guc_ct to select what to
include?

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
>index 72ad576fc18e..686fe664c20d 100644
>--- a/drivers/gpu/drm/xe/xe_guc_ct.c
>+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>@@ -1828,10 +1828,10 @@ static void ct_dead_print(struct xe_dead_ct *dead)
> 		return;
> 	}
>
>-	drm_printf(&lp, "CTB is dead - reason=0x%X\n", dead->reason);
>
> 	/* Can't generate a genuine core dump at this point, so just do the good bits */
> 	drm_puts(&lp, "**** Xe Device Coredump ****\n");
>+	drm_printf(&lp, "Reason: CTB is dead - 0x%X\n", dead->reason);
> 	xe_device_snapshot_print(xe, &lp);
>
> 	drm_printf(&lp, "**** GT #%d ****\n", gt->info.id);
>-- 
>2.49.0
>