✗ CI.checkpatch: warning for Track FAST_REQ H2Gs to report where errors came from

Patchwork patchwork at emeril.freedesktop.org
Wed Mar 26 20:07:45 UTC 2025


== Series Details ==

Series: Track FAST_REQ H2Gs to report where errors came from
URL   : https://patchwork.freedesktop.org/series/146827/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
99e5a866b5e13f134e606a3e29d9508d97826fb3
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c756856342bf54bcae8c3ce4b1878903385557a0
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Wed Mar 26 12:32:39 2025 -0700

    drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
    
    Most H2G messages are FAST_REQ which means no synchronous response is
    expected. The messages are sent as fire-and-forget with no tracking.
    However, errors can still be returned when something goes unexpectedly
    wrong. That leads to confusion due to not being able to match up the
    error response to the originating H2G.
    
    So add support for tracking the FAST_REQ H2Gs and matching up an error
    response to its originator. This is only enabled in XE_DEBUG builds
    given that such errors should never happen in a working system and
    there is an overhead for the tracking.
    
    Further, if XE_DEBUG_GUC is enabled then even more memory and time is
    used to record the call stack of each H2G and report that with the
    error. That makes it much easier to work out where a specific H2G came
    from if there are multiple code paths that can send it.
    
    Note, rather than create an extra Kconfig define for just this
    feature, the XE_LARGE_GUC_BUFFER option has been re-used and renamed
    to XE_DEBUG_GUC and is now just a general purpose 'verbose GuC debug'
    option.
    
    v2: Some re-wording of comments and prints, more consistent use of #if
    vs stub functions - review feedback from Daniele & Michal).
    
    Original-i915-code: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
+ /mt/dim checkpatch 14c330bc015ded4a1f1dd1f5aeb8617077aaa7e8 drm-intel
abdba12da3e4 drm/xe/guc: Add a missing H2G error code definition
c756856342bf drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
-:45: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol
#45: FILE: drivers/gpu/drm/xe/Kconfig.debug:89:
+config DRM_XE_DEBUG_GUC
+        bool "Enable extra GuC related debug options"
+        depends on DRM_XE_DEBUG
         default n
+        select STACKDEPOT
         help
           Choose this option when debugging guc issues.
+          The GuC log buffer is increased to the maximum allowed, which should
+          The GuC log buffer is increased to the maximum allowed, which should
+          be large enough for complex issues. This config also enables
+          recording of the stack when tracking FAST_REQ messages.
 
           Recommended for driver developers only.
 

total: 0 errors, 1 warnings, 0 checks, 199 lines checked




More information about the Intel-xe mailing list