[PATCH] drm/xe: Don't print error about hwconfig when using execlists
Randhawa, Jagmeet
jagmeet.randhawa at intel.com
Fri Mar 28 17:07:56 UTC 2025
On 3/28/2025 8:42 AM, Stuart Summers wrote:
> This error message is only applicable for platforms using
> GuC submission - to warn the user if the GuC they are using
> or the platform they are running doesn't have this information
> to provide to userspace about the platform. When forcing
> execlist submission, which is something only used for debug,
> the user is running at their own risk and should understand
> the limitations of running without GuC.
>
> v2 (John/Lucas): Don't print an info message with execlists
>
> Signed-off-by: Stuart Summers <stuart.summers at intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_mcr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 605aad3554e7..d4d9730f0d2c 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -345,7 +345,8 @@ static unsigned int dss_per_group(struct xe_gt *gt)
> * Some older platforms don't have tables or don't have complete tables.
> * Newer platforms should always have the required info.
> */
> - if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000)
> + if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000 &&
> + !gt_to_xe(gt)->info.force_execlist)
> xe_gt_err(gt, "Slice/Subslice counts missing from hwconfig table; using typical fallback values\n");
>
> if (gt_to_xe(gt)->info.platform == XE_PVC)
Since we're using force_execlist (a debug option to bypass GuC and use
execlist submission), the user already knows they're running without GuC
features. So printing the hwconfig error isn't helpful.
Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa at intel.com>
More information about the Intel-xe
mailing list