✗ CI.checkpatch: warning for drm/xe/pmu: Add GT frequency events (rev7)

[Patchwork]

== Series Details ==

Series: drm/xe/pmu: Add GT frequency events (rev7)
URL   : https://patchwork.freedesktop.org/series/144164/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
99e5a866b5e13f134e606a3e29d9508d97826fb3
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9096f8fd344be2e4c875249a221a7a2cdafd18a2
Author: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Date:   Fri Mar 28 15:53:30 2025 -0700

    drm/xe/pmu: Add GT frequency events
    
    Define PMU events for GT frequency (actual and requested). The
    instantaneous values for these frequencies will be displayed.
    
    Following PMU events are being added:
      xe_0000_00_02.0/gt-actual-frequency/              [Kernel PMU event]
      xe_0000_00_02.0/gt-requested-frequency/           [Kernel PMU event]
    
    Standard perf commands can be used to monitor GT frequency:
      $ perf stat -e xe_0000_00_02.0/gt-requested-frequency,gt=0/ -I1000
    
      1.001229762       1483 Mhz  xe_0000_00_02.0/gt-requested-frequency,gt=0/
      2.006175406       1483 Mhz  xe_0000_00_02.0/gt-requested-frequency,gt=0/
    
    v2: Use locks while storing/reading samples, keep track of multiple
    clients (Lucas) and other general cleanup.
    v3: Review comments (Lucas) and use event counts instead of mask for
    active events.
    v4: Add freq events to event_param_valid method (Riana)
    v5: Use instantaneous values instead of aggregating (Lucas)
    v6: Obtain fwake at init for freq events as well and use non fwake
    variant method for reading requested freq to avoid lockdep issues (Lucas)
    
    Cc: Riana Tauro <riana.tauro at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
+ /mt/dim checkpatch eb7714c3b05163fd19bc811d8f3f249392c5ceda drm-intel
9096f8fd344b drm/xe/pmu: Add GT frequency events
-:98: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#98: FILE: drivers/gpu/drm/xe/xe_pmu.c:127:
+	uint32_t id = config_to_event_id(event->attr.config);

-:164: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#164: FILE: drivers/gpu/drm/xe/xe_pmu.c:471:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                        ^

-:164: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#164: FILE: drivers/gpu/drm/xe/xe_pmu.c:471:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                               ^

-:166: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#166: FILE: drivers/gpu/drm/xe/xe_pmu.c:473:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                        ^

-:166: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#166: FILE: drivers/gpu/drm/xe/xe_pmu.c:473:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                                  ^

total: 0 errors, 0 warnings, 5 checks, 135 lines checked