<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style>
</head>
<body>
<div>On Wed, 2023-07-26 at 19:29 +0000, Matthew Brost wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Wed, Jul 26, 2023 at 03:25:19PM -0400, Rodrigo Vivi wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>This might be an useful debugging information if the driver<br>
</div>
<div>date is properly updated with a certain cadence. With this<br>
</div>
<div>we know from which point in time in our development the<br>
</div>
<div>driver was from.<br>
</div>
<div><br>
</div>
</blockquote>
<div><br>
</div>
<div>Make sense to have this, wondering what the cadence should be...<br>
</div>
</blockquote>
<div><br>
</div>
<div>before we are merged we should probably change the date along with our rebases.</div>
<div><br>
</div>
<div>after we are in tree probably after the latest pull request towards the next version.</div>
<div><br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div><br>
</div>
<div>Anyways:<br>
</div>
<div>Reviewed-by: Matthew Brost <<a href="mailto:matthew.brost@intel.com">matthew.brost@intel.com</a>><br>
</div>
<div> <br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>Signed-off-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>><br>
</div>
<div>---<br>
</div>
<div> drivers/gpu/drm/xe/xe_devcoredump.c | 2 ++<br>
</div>
<div> 1 file changed, 2 insertions(+)<br>
</div>
<div><br>
</div>
<div>diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c<br>
</div>
<div>index f53f4b51233a..79b506dc2622 100644<br>
</div>
<div>--- a/drivers/gpu/drm/xe/xe_devcoredump.c<br>
</div>
<div>+++ b/drivers/gpu/drm/xe/xe_devcoredump.c<br>
</div>
<div>@@ -10,6 +10,7 @@<br>
</div>
<div> #include <generated/utsrelease.h><br>
</div>
<div> <br>
</div>
<div> #include "xe_device.h"<br>
</div>
<div>+#include "xe_drv.h"<br>
</div>
<div> #include "xe_engine.h"<br>
</div>
<div> #include "xe_force_wake.h"<br>
</div>
<div> #include "xe_gt.h"<br>
</div>
<div>@@ -83,6 +84,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,<br>
</div>
<div> drm_printf(&p, "**** Xe Device Coredump ****\n");<br>
</div>
<div> drm_printf(&p, "kernel: " UTS_RELEASE "\n");<br>
</div>
<div> drm_printf(&p, "module: " KBUILD_MODNAME "\n");<br>
</div>
<div>+ drm_printf(&p, "driver date: " DRIVER_DATE "\n");<br>
</div>
<div> <br>
</div>
<div> ts = ktime_to_timespec64(ss->snapshot_time);<br>
</div>
<div> drm_printf(&p, "Snapshot time: %lld.%09ld\n", ts.tv_sec, ts.tv_nsec);<br>
</div>
<div>-- <br>
</div>
<div>2.41.0<br>
</div>
<div><br>
</div>
</blockquote>
</blockquote>
<div><br>
</div>
<div><span></span></div>
</body>
</html>