<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">
<pre>On 31/08/23 03:49, Dixit, Ashutosh wrote:</pre>
</div>
<blockquote type="cite"
cite="mid:87bkeo18df.wl-ashutosh.dixit@intel.com">
<pre class="moz-quote-pre" wrap="">On Wed, 30 Aug 2023 13:56:57 -0700, Rodrigo Vivi wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
On Tue, Aug 29, 2023 at 10:33:02PM -0700, Dixit, Ashutosh wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Tue, 29 Aug 2023 22:15:43 -0700, Aravind Iddamsetty wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Hi Aravind,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">@@ -162,7 +162,7 @@ int xe_force_wake_get(struct xe_force_wake *fw,
domain->id, ret);
}
fw->awake_domains |= woken;
- mutex_unlock(&fw->lock);
+ spin_unlock(&fw->lock);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
No need to change anything yet, but let's get some more opinion on this: is
it ok to (a) just replace the mutex with a spinlock in these force_wake
functions, or, (b) should we have a second set of functions to be called in
atomic context, say: xe_force_wake_get/put_atomic? So we should use (b) in
atomic contexts and everywhere else we just continue to use the previous
set of non-atomic functions? Or just converting the default set of
functions to use spin lock (as is done in this patch) is ok?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
It looks okay to me,
Reviewed-by: Rodrigo Vivi <a class="moz-txt-link-rfc2396E" href="mailto:rodrigo.vivi@intel.com"><rodrigo.vivi@intel.com></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Still thinking about this, maybe some time (not part of this series) we
should do a power measurement comparison between mutex and spinlock and see
if there's an appreciable difference (unless we already know?). But till we
do that, this is fine, so this is also:
Reviewed-by: Ashutosh Dixit <a class="moz-txt-link-rfc2396E" href="mailto:ashutosh.dixit@intel.com"><ashutosh.dixit@intel.com></a></pre>
</blockquote>
<pre>Thanks Rodrigo and Ashutosh for your r-b.</pre>
<pre>Regards,</pre>
<pre>Aravind.
</pre>
<blockquote type="cite"
cite="mid:87bkeo18df.wl-ashutosh.dixit@intel.com">
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
</html>